Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Unified Diff: runtime/BUILD.gn

Issue 2940513002: Revert "[fuchsia] Prepare for setting the Dart target architecture appropriately in the host binari… (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/bin/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/BUILD.gn
diff --git a/runtime/BUILD.gn b/runtime/BUILD.gn
index caf6496fac155570cdad0e10e9541b9245e165e1..2713c7c6ec8528adb7050ede86c754fd2d24ea5d 100644
--- a/runtime/BUILD.gn
+++ b/runtime/BUILD.gn
@@ -72,11 +72,27 @@ config("dart_no_snapshot_config") {
defines += [ "DART_NO_SNAPSHOT" ]
}
-# TODO(rmacnak): If Fuchsia adds a checked-in SDK, this should be folded back
-# into dart_config
-config("dart_use_target_arch_config") {
+config("dart_config") {
defines = []
+ if (target_os == "android") {
+ defines += [ "TARGET_OS_ANDROID" ]
+ } else if (target_os == "fuchsia") {
+ defines += [ "TARGET_OS_FUCHSIA" ]
+ } else if (target_os == "ios") {
+ defines += [ "TARGET_OS_MACOS" ]
+ defines += [ "TARGET_OS_MACOS_IOS" ]
+ } else if (target_os == "linux") {
+ defines += [ "TARGET_OS_LINUX" ]
+ } else if (target_os == "mac") {
+ defines += [ "TARGET_OS_MACOS" ]
+ } else if (target_os == "win") {
+ defines += [ "TARGET_OS_WINDOWS" ]
+ } else {
+ print("Unknown target_os: $target_os")
+ assert(false)
+ }
+
if (dart_target_arch != "") {
if (dart_target_arch == "arm" || dart_target_arch == "simarm") {
defines += [ "TARGET_ARCH_ARM" ]
@@ -106,28 +122,6 @@ config("dart_use_target_arch_config") {
assert(false)
}
}
-}
-
-config("dart_config") {
- defines = []
-
- if (target_os == "android") {
- defines += [ "TARGET_OS_ANDROID" ]
- } else if (target_os == "fuchsia") {
- defines += [ "TARGET_OS_FUCHSIA" ]
- } else if (target_os == "ios") {
- defines += [ "TARGET_OS_MACOS" ]
- defines += [ "TARGET_OS_MACOS_IOS" ]
- } else if (target_os == "linux") {
- defines += [ "TARGET_OS_LINUX" ]
- } else if (target_os == "mac") {
- defines += [ "TARGET_OS_MACOS" ]
- } else if (target_os == "win") {
- defines += [ "TARGET_OS_WINDOWS" ]
- } else {
- print("Unknown target_os: $target_os")
- assert(false)
- }
if (dart_debug) {
defines += [ "DEBUG" ]
@@ -229,7 +223,6 @@ template("libdart_library") {
}
libdart_library("libdart_jit") {
- extra_configs = [ ":dart_use_target_arch_config" ]
extra_deps = [
"vm:libdart_lib_jit",
"vm:libdart_vm_jit",
@@ -237,10 +230,7 @@ libdart_library("libdart_jit") {
}
libdart_library("libdart_precompiled_runtime") {
- extra_configs = [
- ":dart_precompiled_runtime_config",
- ":dart_use_target_arch_config",
- ]
+ extra_configs = [ ":dart_precompiled_runtime_config" ]
extra_deps = [
"vm:libdart_lib_precompiled_runtime",
"vm:libdart_vm_precompiled_runtime",
@@ -251,7 +241,6 @@ libdart_library("libdart_nosnapshot_with_precompiler") {
extra_configs = [
":dart_no_snapshot_config",
":dart_precompiler_config",
- ":dart_use_target_arch_config",
]
extra_deps = [
"vm:libdart_lib_nosnapshot_with_precompiler",
@@ -259,23 +248,8 @@ libdart_library("libdart_nosnapshot_with_precompiler") {
]
}
-# TODO(rmacnak): Remove if Fuchsia adds a checked-in SDK.
-libdart_library("libdart_nosnapshot_with_precompiler_host_arch") {
- extra_configs = [
- ":dart_no_snapshot_config",
- ":dart_precompiler_config",
- ]
- extra_deps = [
- "vm:libdart_lib_nosnapshot_with_precompiler_host_arch",
- "vm:libdart_vm_nosnapshot_with_precompiler_host_arch",
- ]
-}
-
libdart_library("libdart_with_precompiler") {
- extra_configs = [
- ":dart_precompiler_config",
- ":dart_use_target_arch_config",
- ]
+ extra_configs = [ ":dart_precompiler_config" ]
extra_deps = [
"vm:libdart_lib_with_precompiler",
"vm:libdart_vm_with_precompiler",
« no previous file with comments | « no previous file | runtime/bin/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698