Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2940473002: Generate vmservice_io.dill along with platform.dill. (Closed)

Created:
3 years, 6 months ago by sivachandra
Modified:
3 years, 6 months ago
Reviewers:
siva
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Generate vmservice_io.dill along with platform.dill. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/1fe6097cc8220de8fd1fdc8852ea9f894747512c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M tools/patch_sdk.dart View 3 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
sivachandra
This change depends on https://codereview.chromium.org/2931193002/.
3 years, 6 months ago (2017-06-12 21:10:48 UTC) #2
siva
lgtm
3 years, 6 months ago (2017-06-12 21:32:03 UTC) #3
sivachandra
3 years, 6 months ago (2017-06-13 22:40:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1fe6097cc8220de8fd1fdc8852ea9f894747512c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698