Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1126)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/fasta_accessors.dart

Issue 2940453002: Add offsets to the `== null` calls inserted by null-aware desugaring. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/kernel/fasta_accessors.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/fasta_accessors.dart b/pkg/front_end/lib/src/fasta/kernel/fasta_accessors.dart
index 78420049dd2423fb4dca874cf50e60568dbb7fb0..3faa1e44d3b62cc2e093dea78bbe0e7ba17fe3c0 100644
--- a/pkg/front_end/lib/src/fasta/kernel/fasta_accessors.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/fasta_accessors.dart
@@ -277,7 +277,8 @@ abstract class ErrorAccessor implements FastaAccessor {
}
@override
- Expression buildNullAwareAssignment(Expression value, DartType type,
+ Expression buildNullAwareAssignment(
+ Expression value, DartType type, int offset,
{bool voidContext: false}) {
return buildError(new KernelArguments(<Expression>[value]), isSetter: true);
}
@@ -393,7 +394,8 @@ class ThisAccessor extends FastaAccessor {
return buildAssignmentError();
}
- Expression buildNullAwareAssignment(Expression value, DartType type,
+ Expression buildNullAwareAssignment(
+ Expression value, DartType type, int offset,
{bool voidContext: false}) {
return buildAssignmentError();
}
@@ -504,7 +506,8 @@ class SendAccessor extends IncompleteSend {
isNullAware: isNullAware);
}
- Expression buildNullAwareAssignment(Expression value, DartType type,
+ Expression buildNullAwareAssignment(
+ Expression value, DartType type, int offset,
{bool voidContext: false}) {
return internalError("Unhandled");
}
@@ -569,7 +572,8 @@ class IncompletePropertyAccessor extends IncompleteSend {
helper, token, helper.toValue(receiver), name, null, null, isNullAware);
}
- Expression buildNullAwareAssignment(Expression value, DartType type,
+ Expression buildNullAwareAssignment(
+ Expression value, DartType type, int offset,
{bool voidContext: false}) {
return internalError("Unhandled");
}

Powered by Google App Engine
This is Rietveld 408576698