Add offsets to the `== null` calls inserted by null-aware desugaring.

Add offsets to the `== null` calls inserted by null-aware desugaring.

This makes it possible to close a gap in testing instrumentation:
previously any annotations that were missing a file offset got
silently dropped.

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/31e2b4ac84c028d5d0bbb7f0298436357fe4a036

[Paul Berry, 2017-06-12 20:17:23]

paulberry@google.com changed reviewers:
+ ahe@google.com, scheglov@google.com

[Paul Berry, 2017-06-12 20:17:24]

Konstantin, can you give this a preliminary review since you're on US time?

I won't land until I have a review from Peter.

https://codereview.chromium.org/2940453002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart (right):

https://codereview.chromium.org/2940453002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart:686: Expression
buildIsNull(Expression value, int offset) {
Note: I changed `offset` to a required argument here so that it wouldn't be
forgotten by mistake.

[scheglov, 2017-06-12 20:23:50]

LGTM

[ahe, 2017-06-12 20:36:45]

Don't wait for my review. I skimmed this and it looks nice!

[Paul Berry, 2017-06-12 21:06:55]

Description was changed from

==========
Add offsets to the `== null` calls inserted by null-aware desugaring.

This makes it possible to close a gap in testing instrumentation:
previously any annotations that were missing a file offset got
silently dropped.
==========

to

==========
Add offsets to the `== null` calls inserted by null-aware desugaring.

This makes it possible to close a gap in testing instrumentation:
previously any annotations that were missing a file offset got
silently dropped.

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/31e2b4ac84c028d5d0bbb7f0298436357fe4a036
==========

[Paul Berry, 2017-06-12 21:07:00]

Committed patchset #1 (id:1) manually as
31e2b4ac84c028d5d0bbb7f0298436357fe4a036 (presubmit successful).