Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 294043016: Refactor java packages. (Closed)

Created:
6 years, 7 months ago by qsr
Modified:
6 years, 6 months ago
Reviewers:
viettrungluu, rmcilroy
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Refactor java packages. - Move implementation into its own .impl package. - Move MojoTestCase to the .mojo package. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273310

Patch Set 1 #

Total comments: 2

Patch Set 2 : Follow review #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -1918 lines) Patch
A + mojo/android/javatests/src/org/chromium/mojo/MojoTestCase.java View 2 1 chunk +1 line, -1 line 0 comments Download
D mojo/android/javatests/src/org/chromium/mojo/system/CoreTest.java View 2 1 chunk +0 lines, -790 lines 0 comments Download
D mojo/android/javatests/src/org/chromium/mojo/system/MojoTestCase.java View 2 1 chunk +0 lines, -49 lines 0 comments Download
A + mojo/android/javatests/src/org/chromium/mojo/system/impl/CoreImplTest.java View 1 2 2 chunks +13 lines, -2 lines 0 comments Download
D mojo/android/system/src/org/chromium/mojo/system/CoreImpl.java View 2 1 chunk +0 lines, -654 lines 0 comments Download
D mojo/android/system/src/org/chromium/mojo/system/DataPipeConsumerHandleImpl.java View 1 chunk +0 lines, -63 lines 0 comments Download
D mojo/android/system/src/org/chromium/mojo/system/DataPipeProducerHandleImpl.java View 1 chunk +0 lines, -55 lines 0 comments Download
D mojo/android/system/src/org/chromium/mojo/system/HandleBase.java View 1 chunk +0 lines, -119 lines 0 comments Download
D mojo/android/system/src/org/chromium/mojo/system/MessagePipeHandleImpl.java View 2 1 chunk +0 lines, -47 lines 0 comments Download
D mojo/android/system/src/org/chromium/mojo/system/SharedBufferHandleImpl.java View 1 chunk +0 lines, -52 lines 0 comments Download
D mojo/android/system/src/org/chromium/mojo/system/UntypedHandleImpl.java View 1 chunk +0 lines, -61 lines 0 comments Download
A + mojo/android/system/src/org/chromium/mojo/system/impl/CoreImpl.java View 2 11 chunks +20 lines, -14 lines 0 comments Download
A + mojo/android/system/src/org/chromium/mojo/system/impl/DataPipeConsumerHandleImpl.java View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/android/system/src/org/chromium/mojo/system/impl/DataPipeProducerHandleImpl.java View 4 chunks +4 lines, -4 lines 0 comments Download
A + mojo/android/system/src/org/chromium/mojo/system/impl/HandleBase.java View 1 chunk +3 lines, -1 line 0 comments Download
A + mojo/android/system/src/org/chromium/mojo/system/impl/MessagePipeHandleImpl.java View 2 1 chunk +4 lines, -1 line 0 comments Download
A + mojo/android/system/src/org/chromium/mojo/system/impl/SharedBufferHandleImpl.java View 1 chunk +3 lines, -1 line 0 comments Download
A + mojo/android/system/src/org/chromium/mojo/system/impl/UntypedHandleImpl.java View 1 chunk +4 lines, -1 line 0 comments Download
M mojo/mojo.gyp View 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
qsr
6 years, 7 months ago (2014-05-23 14:41:04 UTC) #1
rmcilroy
lgtm with one suggestion. https://codereview.chromium.org/294043016/diff/1/mojo/android/javatests/src/org/chromium/mojo/system/impl/CoreTest.java File mojo/android/javatests/src/org/chromium/mojo/system/impl/CoreTest.java (right): https://codereview.chromium.org/294043016/diff/1/mojo/android/javatests/src/org/chromium/mojo/system/impl/CoreTest.java#newcode42 mojo/android/javatests/src/org/chromium/mojo/system/impl/CoreTest.java:42: public class CoreTest extends MojoTestCase ...
6 years, 7 months ago (2014-05-23 16:03:41 UTC) #2
qsr
https://codereview.chromium.org/294043016/diff/1/mojo/android/javatests/src/org/chromium/mojo/system/impl/CoreTest.java File mojo/android/javatests/src/org/chromium/mojo/system/impl/CoreTest.java (right): https://codereview.chromium.org/294043016/diff/1/mojo/android/javatests/src/org/chromium/mojo/system/impl/CoreTest.java#newcode42 mojo/android/javatests/src/org/chromium/mojo/system/impl/CoreTest.java:42: public class CoreTest extends MojoTestCase { On 2014/05/23 16:03:41, ...
6 years, 7 months ago (2014-05-23 16:31:49 UTC) #3
viettrungluu
lgtm
6 years, 6 months ago (2014-05-27 16:26:44 UTC) #4
qsr
The CQ bit was checked by qsr@chromium.org
6 years, 6 months ago (2014-05-28 14:08:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/294043016/40001
6 years, 6 months ago (2014-05-28 14:09:14 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium ...
6 years, 6 months ago (2014-05-28 15:50:16 UTC) #7
qsr
The CQ bit was unchecked by qsr@chromium.org
6 years, 6 months ago (2014-05-28 16:10:00 UTC) #8
qsr
The CQ bit was checked by qsr@chromium.org
6 years, 6 months ago (2014-05-28 16:10:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/294043016/40001
6 years, 6 months ago (2014-05-28 16:10:16 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-05-28 19:03:34 UTC) #11
Message was sent while issue was closed. 
Change committed as 273310

Powered by Google App Engine
This is Rietveld 408576698