Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1209)

Unified Diff: content/renderer/render_frame_impl.h

Issue 294043015: Move creation of MediaStream renders from MediaStreamImpl to MediaStreamRenderFactory (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Self review. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.h
diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h
index 7d9171cdcdc32e2e7c4ac881e9bce6b40ba8cb48..1037a55e53080fbd2feb7d05d60163a93a474955 100644
--- a/content/renderer/render_frame_impl.h
+++ b/content/renderer/render_frame_impl.h
@@ -54,7 +54,7 @@ class Rect;
namespace content {
class ChildFrameCompositingHelper;
-class MediaStreamClient;
+class MediaStreamRendererFactory;
class NotificationProvider;
class PepperPluginInstanceImpl;
class RendererPpapiHost;
@@ -188,10 +188,6 @@ class CONTENT_EXPORT RenderFrameImpl
bool keep_selection);
#endif // ENABLE_PLUGINS
- // Overrides the MediaStreamClient used when creating MediaStream players.
- // Must be called before any players are created.
- void SetMediaStreamClientForTesting(MediaStreamClient* media_stream_client);
-
// IPC::Sender
virtual bool Send(IPC::Message* msg) OVERRIDE;
@@ -396,7 +392,7 @@ class CONTENT_EXPORT RenderFrameImpl
friend class RenderFrameObserver;
FRIEND_TEST_ALL_PREFIXES(RendererAccessibilityTest,
AccessibilityMessagesQueueWhileSwappedOut);
- FRIEND_TEST_ALL_PREFIXES(RenderFrameImplTest,
+ FRIEND_TEST_ALL_PREFIXES(RenderFrameImplTest,
ShouldUpdateSelectionTextFromContextMenuParams);
FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest,
OnExtendSelectionAndDelete);
@@ -511,15 +507,19 @@ class CONTENT_EXPORT RenderFrameImpl
const blink::WebURLError& error,
bool replace);
- // Initializes |media_stream_client_|, returning true if successful. Returns
+ // Initializes |web_user_media_client_|, returning true if successful. Returns
// false if it wasn't possible to create a MediaStreamClient (e.g., WebRTC is
- // disabled) in which case |media_stream_client_| is NULL.
- bool InitializeMediaStreamClient();
+ // disabled) in which case |web_user_media_client_| is NULL.
+ bool InitializeUserMediaClient();
blink::WebMediaPlayer* CreateWebMediaPlayerForMediaStream(
const blink::WebURL& url,
blink::WebMediaPlayerClient* client);
+ // Creates a factory object used for creating audio and video renderers.
+ // The method is virtual so that layouttests can override it.
+ virtual scoped_ptr<MediaStreamRendererFactory> CreateRendererFactory();
+
#if defined(OS_ANDROID)
blink::WebMediaPlayer* CreateAndroidWebMediaPlayer(
const blink::WebURL& url,
@@ -589,8 +589,6 @@ class CONTENT_EXPORT RenderFrameImpl
// Holds a reference to the service which provides desktop notifications.
NotificationProvider* notification_provider_;
- // MediaStreamClient attached to this frame; lazily initialized.
- MediaStreamClient* media_stream_client_;
blink::WebUserMediaClient* web_user_media_client_;
base::WeakPtrFactory<RenderFrameImpl> weak_factory_;

Powered by Google App Engine
This is Rietveld 408576698