Issue 294043012: No need to have RequestPeer as a data member variable of IPCResourceLoaderBridge.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 294043012: No need to have RequestPeer as a data member variable of IPCResourceLoaderBridge. (Closed)

Created:
6 years, 7 months ago by tfarina

Modified:
6 years, 7 months ago

Reviewers:
jam

CC:
chromium-reviews, darin (slow to review)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

No need to have RequestPeer as a data member variable of IPCResourceLoaderBridge. It seems we can just pass |peer| directly to AddPendingRequest() function and thus remove this variable, simplifying IPCResourceLoaderBridge. BUG=265753, 338338, 237249 TEST=content_shell + content_unittests R=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272787

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -7 lines)			Patch
	M	content/child/resource_dispatcher.cc	View		3 chunks	+2 lines, -7 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/294043012/1

6 years, 7 months ago (2014-05-25 05:06:05 UTC) #4

Message was sent while issue was closed.

Change committed as 272787