Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2482)

Unified Diff: chrome/browser/metrics/metrics_service.cc

Issue 294043008: Introduce AndroidMetricsProvider class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/metrics/metrics_service.h ('k') | chrome/browser/metrics/metrics_service_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/metrics_service.cc
===================================================================
--- chrome/browser/metrics/metrics_service.cc (revision 272124)
+++ chrome/browser/metrics/metrics_service.cc (working copy)
@@ -235,7 +235,10 @@
#include "base/win/registry.h"
#endif
-#if !defined(OS_ANDROID)
+#if defined(OS_ANDROID)
+// TODO(asvitkine): Move this out of MetricsService.
+#include "chrome/browser/metrics/android_metrics_provider.h"
+#else
#include "chrome/browser/service_process/service_process_control.h"
#endif
@@ -454,7 +457,8 @@
registry->RegisterInt64Pref(prefs::kUninstallLastObservedRunTimeSec, 0);
#if defined(OS_ANDROID)
- RegisterPrefsAndroid(registry);
+ // TODO(asvitkine): Move this out of here.
+ AndroidMetricsProvider::RegisterPrefs(registry);
#endif // defined(OS_ANDROID)
}
@@ -480,8 +484,15 @@
DCHECK(state_manager_);
DCHECK(client_);
+#if defined(OS_ANDROID)
// TODO(asvitkine): Move this out of MetricsService.
RegisterMetricsProvider(
+ scoped_ptr<metrics::MetricsProvider>(new AndroidMetricsProvider(
+ g_browser_process->local_state())));
+#endif // defined(OS_ANDROID)
+
+ // TODO(asvitkine): Move this out of MetricsService.
+ RegisterMetricsProvider(
scoped_ptr<metrics::MetricsProvider>(new OmniboxMetricsProvider));
BrowserChildProcessObserver::Add(this);
@@ -822,10 +833,6 @@
session_id_ = pref->GetInteger(prefs::kMetricsSessionID);
-#if defined(OS_ANDROID)
- LogAndroidStabilityToPrefs(pref);
-#endif // defined(OS_ANDROID)
-
if (!pref->GetBoolean(prefs::kStabilityExitedCleanly)) {
IncrementPrefValue(prefs::kStabilityCrashCount);
// Reset flag, and wait until we call LogNeedForCleanShutdown() before
@@ -1409,11 +1416,7 @@
static_cast<MetricsLog*>(log_manager_.current_log());
current_log->RecordStabilityMetrics(metrics_providers_.get(),
base::TimeDelta(), base::TimeDelta());
-
-#if defined(OS_ANDROID)
- ConvertAndroidStabilityPrefsToHistograms(pref);
RecordCurrentStabilityHistograms();
-#endif // defined(OS_ANDROID)
// Note: RecordGeneralMetrics() intentionally not called since this log is for
// stability stats from a previous session only.
@@ -1453,10 +1456,6 @@
static_cast<MetricsLog*>(log_manager_.current_log());
current_log->RecordStabilityMetrics(metrics_providers_.get(),
base::TimeDelta(), base::TimeDelta());
-
-#if defined(OS_ANDROID)
- ConvertAndroidStabilityPrefsToHistograms(pref);
-#endif // defined(OS_ANDROID)
RecordCurrentHistograms();
current_log->RecordGeneralMetrics(metrics_providers_.get());
« no previous file with comments | « chrome/browser/metrics/metrics_service.h ('k') | chrome/browser/metrics/metrics_service_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698