Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1516)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/BUILD.gn

Issue 2940403002: Move SafeBrowsing files from //chrome/browser to a separate target. (Closed)
Patch Set: . Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/BUILD.gn
diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn
index a97a8ba3c84031366d3b1d73bb876ecb9793533f..2c38327d7c8d972eceadcaf5ab06a842dee367c2 100644
--- a/chrome/browser/BUILD.gn
+++ b/chrome/browser/BUILD.gn
@@ -1162,32 +1162,6 @@ split_static_library("browser") {
"resource_delegate_mac.mm",
"resources_util.cc",
"resources_util.h",
- "safe_browsing/browser_url_loader_throttle.cc",
- "safe_browsing/browser_url_loader_throttle.h",
- "safe_browsing/chrome_cleaner/chrome_cleaner_controller_win.cc",
- "safe_browsing/chrome_cleaner/chrome_cleaner_controller_win.h",
- "safe_browsing/chrome_cleaner/chrome_cleaner_fetcher_win.cc",
- "safe_browsing/chrome_cleaner/chrome_cleaner_fetcher_win.h",
- "safe_browsing/chrome_cleaner/chrome_cleaner_runner_win.cc",
- "safe_browsing/chrome_cleaner/chrome_cleaner_runner_win.h",
- "safe_browsing/chrome_cleaner/reporter_runner_win.cc",
- "safe_browsing/chrome_cleaner/reporter_runner_win.h",
- "safe_browsing/chrome_cleaner/settings_resetter_win.cc",
- "safe_browsing/chrome_cleaner/settings_resetter_win.h",
- "safe_browsing/chrome_cleaner/srt_chrome_prompt_impl.cc",
- "safe_browsing/chrome_cleaner/srt_chrome_prompt_impl.h",
- "safe_browsing/chrome_cleaner/srt_client_info_win.cc",
- "safe_browsing/chrome_cleaner/srt_client_info_win.h",
- "safe_browsing/chrome_cleaner/srt_field_trial_win.cc",
- "safe_browsing/chrome_cleaner/srt_field_trial_win.h",
- "safe_browsing/chrome_cleaner/srt_global_error_win.cc",
- "safe_browsing/chrome_cleaner/srt_global_error_win.h",
- "safe_browsing/mojo_safe_browsing_impl.cc",
- "safe_browsing/mojo_safe_browsing_impl.h",
- "safe_browsing/safe_browsing_tab_observer.cc",
- "safe_browsing/safe_browsing_tab_observer.h",
- "safe_browsing/safe_browsing_url_checker_impl.cc",
- "safe_browsing/safe_browsing_url_checker_impl.h",
"safe_search_api/safe_search_url_checker.cc",
"safe_search_api/safe_search_url_checker.h",
"search/iframe_source.cc",
@@ -1496,6 +1470,7 @@ split_static_library("browser") {
"//chrome/browser/media/router",
"//chrome/browser/metrics/variations:chrome_ui_string_overrider_factory",
"//chrome/browser/net:probe_message_proto",
+ "//chrome/browser/safe_browsing",
"//chrome/browser/ssl:proto",
"//chrome/browser/ui",
"//chrome/common/net",
@@ -1586,7 +1561,6 @@ split_static_library("browser") {
"//components/rappor:rappor_recorder",
"//components/renderer_context_menu",
"//components/resources",
- "//components/safe_browsing/common:interfaces",
"//components/safe_json",
"//components/search",
"//components/search_engines",
@@ -1833,20 +1807,6 @@ split_static_library("browser") {
"renderer_context_menu/context_menu_content_type_platform_app.h",
"renderer_host/chrome_extension_message_filter.cc",
"renderer_host/chrome_extension_message_filter.h",
- "safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller_win.cc",
- "safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller_win.h",
- "safe_browsing/settings_reset_prompt/default_settings_fetcher.cc",
- "safe_browsing/settings_reset_prompt/default_settings_fetcher.h",
- "safe_browsing/settings_reset_prompt/extension_info.cc",
- "safe_browsing/settings_reset_prompt/extension_info.h",
- "safe_browsing/settings_reset_prompt/settings_reset_prompt_config.cc",
- "safe_browsing/settings_reset_prompt/settings_reset_prompt_config.h",
- "safe_browsing/settings_reset_prompt/settings_reset_prompt_controller.cc",
- "safe_browsing/settings_reset_prompt/settings_reset_prompt_controller.h",
- "safe_browsing/settings_reset_prompt/settings_reset_prompt_model.cc",
- "safe_browsing/settings_reset_prompt/settings_reset_prompt_model.h",
- "safe_browsing/settings_reset_prompt/settings_reset_prompt_prefs_manager.cc",
- "safe_browsing/settings_reset_prompt/settings_reset_prompt_prefs_manager.h",
"search/hotword_audio_history_handler.cc",
"search/hotword_audio_history_handler.h",
"search/hotword_client.h",
@@ -2252,184 +2212,6 @@ split_static_library("browser") {
]
}
- if (safe_browsing_mode != 0) {
- # "Safe Browsing Basic" files used for safe browsing in full mode
- # (safe_browsing=1) and mobile (=2)
- sources += [
- "loader/data_reduction_proxy_resource_throttle_android.cc",
- "loader/data_reduction_proxy_resource_throttle_android.h",
- "safe_browsing/certificate_reporting_metrics_provider.cc",
- "safe_browsing/certificate_reporting_metrics_provider.h",
- "safe_browsing/certificate_reporting_service.cc",
- "safe_browsing/certificate_reporting_service.h",
- "safe_browsing/certificate_reporting_service_factory.cc",
- "safe_browsing/certificate_reporting_service_factory.h",
- "safe_browsing/notification_image_reporter.cc",
- "safe_browsing/notification_image_reporter.h",
- "safe_browsing/permission_reporter.cc",
- "safe_browsing/permission_reporter.h",
- "safe_browsing/ping_manager.cc",
- "safe_browsing/ping_manager.h",
- "safe_browsing/safe_browsing_blocking_page.cc",
- "safe_browsing/safe_browsing_blocking_page.h",
- "safe_browsing/safe_browsing_navigation_observer.cc",
- "safe_browsing/safe_browsing_navigation_observer.h",
- "safe_browsing/safe_browsing_navigation_observer_manager.cc",
- "safe_browsing/safe_browsing_navigation_observer_manager.h",
- "safe_browsing/safe_browsing_service.cc",
- "safe_browsing/safe_browsing_service.h",
- "safe_browsing/services_delegate.h",
- "safe_browsing/test_safe_browsing_blocking_page_quiet.cc",
- "safe_browsing/test_safe_browsing_blocking_page_quiet.h",
- "safe_browsing/test_safe_browsing_service.cc",
- "safe_browsing/test_safe_browsing_service.h",
- "safe_browsing/ui_manager.cc",
- "safe_browsing/ui_manager.h",
- ]
- deps += [
- "//chrome/browser/safe_browsing:chunk_proto",
- "//chrome/common/safe_browsing:proto",
- "//components/safe_browsing:csd_proto",
- "//components/safe_browsing:safe_browsing",
- "//components/safe_browsing/browser:browser",
- "//components/safe_browsing/common:common",
- "//components/safe_browsing/password_protection",
- "//components/safe_browsing/triggers:triggers",
- "//components/safe_browsing_db:metadata_proto",
- ]
- if (safe_browsing_mode == 1) {
- # "Safe Browsing Full" files in addition to the "basic" ones to use for
- # full safe browsing. This has some in common with "mobile."
- sources += [
- "download/download_completion_blocker.cc",
- "download/download_completion_blocker.h",
- "loader/safe_browsing_resource_throttle.cc",
- "loader/safe_browsing_resource_throttle.h",
- "safe_browsing/browser_feature_extractor.cc",
- "safe_browsing/browser_feature_extractor.h",
- "safe_browsing/browser_features.cc",
- "safe_browsing/browser_features.h",
- "safe_browsing/chrome_password_protection_service.cc",
- "safe_browsing/chrome_password_protection_service.h",
- "safe_browsing/chunk_range.cc",
- "safe_browsing/chunk_range.h",
- "safe_browsing/client_side_detection_host.cc",
- "safe_browsing/client_side_detection_host.h",
- "safe_browsing/client_side_detection_service.cc",
- "safe_browsing/client_side_detection_service.h",
- "safe_browsing/client_side_model_loader.cc",
- "safe_browsing/client_side_model_loader.h",
- "safe_browsing/download_feedback.cc",
- "safe_browsing/download_feedback.h",
- "safe_browsing/download_feedback_service.cc",
- "safe_browsing/download_feedback_service.h",
- "safe_browsing/download_protection_service.cc",
- "safe_browsing/download_protection_service.h",
- "safe_browsing/incident_reporting/binary_integrity_analyzer.cc",
- "safe_browsing/incident_reporting/binary_integrity_analyzer.h",
- "safe_browsing/incident_reporting/binary_integrity_analyzer_mac.cc",
- "safe_browsing/incident_reporting/binary_integrity_analyzer_mac.h",
- "safe_browsing/incident_reporting/binary_integrity_analyzer_win.cc",
- "safe_browsing/incident_reporting/binary_integrity_analyzer_win.h",
- "safe_browsing/incident_reporting/binary_integrity_incident.cc",
- "safe_browsing/incident_reporting/binary_integrity_incident.h",
- "safe_browsing/incident_reporting/blacklist_load_analyzer.cc",
- "safe_browsing/incident_reporting/blacklist_load_analyzer.h",
- "safe_browsing/incident_reporting/blacklist_load_analyzer_win.cc",
- "safe_browsing/incident_reporting/blacklist_load_incident.cc",
- "safe_browsing/incident_reporting/blacklist_load_incident.h",
- "safe_browsing/incident_reporting/delayed_analysis_callback.h",
- "safe_browsing/incident_reporting/delayed_callback_runner.cc",
- "safe_browsing/incident_reporting/delayed_callback_runner.h",
- "safe_browsing/incident_reporting/download_metadata_manager.cc",
- "safe_browsing/incident_reporting/download_metadata_manager.h",
- "safe_browsing/incident_reporting/environment_data_collection.cc",
- "safe_browsing/incident_reporting/environment_data_collection.h",
- "safe_browsing/incident_reporting/environment_data_collection_win.cc",
- "safe_browsing/incident_reporting/environment_data_collection_win.h",
- "safe_browsing/incident_reporting/extension_data_collection.cc",
- "safe_browsing/incident_reporting/extension_data_collection.h",
- "safe_browsing/incident_reporting/incident.cc",
- "safe_browsing/incident_reporting/incident.h",
- "safe_browsing/incident_reporting/incident_handler_util.cc",
- "safe_browsing/incident_reporting/incident_handler_util.h",
- "safe_browsing/incident_reporting/incident_receiver.h",
- "safe_browsing/incident_reporting/incident_report_uploader.cc",
- "safe_browsing/incident_reporting/incident_report_uploader.h",
- "safe_browsing/incident_reporting/incident_report_uploader_impl.cc",
- "safe_browsing/incident_reporting/incident_report_uploader_impl.h",
- "safe_browsing/incident_reporting/incident_reporting_service.cc",
- "safe_browsing/incident_reporting/incident_reporting_service.h",
- "safe_browsing/incident_reporting/last_download_finder.cc",
- "safe_browsing/incident_reporting/last_download_finder.h",
- "safe_browsing/incident_reporting/module_integrity_verifier_win.cc",
- "safe_browsing/incident_reporting/module_integrity_verifier_win.h",
- "safe_browsing/incident_reporting/module_load_analyzer.cc",
- "safe_browsing/incident_reporting/module_load_analyzer.h",
- "safe_browsing/incident_reporting/module_load_analyzer_win.cc",
- "safe_browsing/incident_reporting/platform_state_store.cc",
- "safe_browsing/incident_reporting/platform_state_store.h",
- "safe_browsing/incident_reporting/platform_state_store_win.cc",
- "safe_browsing/incident_reporting/preference_validation_delegate.cc",
- "safe_browsing/incident_reporting/preference_validation_delegate.h",
- "safe_browsing/incident_reporting/resource_request_detector.cc",
- "safe_browsing/incident_reporting/resource_request_detector.h",
- "safe_browsing/incident_reporting/resource_request_incident.cc",
- "safe_browsing/incident_reporting/resource_request_incident.h",
- "safe_browsing/incident_reporting/state_store.cc",
- "safe_browsing/incident_reporting/state_store.h",
- "safe_browsing/incident_reporting/suspicious_module_incident.cc",
- "safe_browsing/incident_reporting/suspicious_module_incident.h",
- "safe_browsing/incident_reporting/tracked_preference_incident.cc",
- "safe_browsing/incident_reporting/tracked_preference_incident.h",
- "safe_browsing/incident_reporting/variations_seed_signature_analyzer.cc",
- "safe_browsing/incident_reporting/variations_seed_signature_analyzer.h",
- "safe_browsing/incident_reporting/variations_seed_signature_incident.cc",
- "safe_browsing/incident_reporting/variations_seed_signature_incident.h",
- "safe_browsing/local_database_manager.cc",
- "safe_browsing/local_database_manager.h",
- "safe_browsing/path_sanitizer.cc",
- "safe_browsing/path_sanitizer.h",
- "safe_browsing/protocol_manager.cc",
- "safe_browsing/protocol_manager.h",
- "safe_browsing/protocol_parser.cc",
- "safe_browsing/protocol_parser.h",
- "safe_browsing/safe_browsing_database.cc",
- "safe_browsing/safe_browsing_database.h",
- "safe_browsing/safe_browsing_store.cc",
- "safe_browsing/safe_browsing_store.h",
- "safe_browsing/safe_browsing_store_file.cc",
- "safe_browsing/safe_browsing_store_file.h",
- "safe_browsing/safe_browsing_util.cc",
- "safe_browsing/safe_browsing_util.h",
- "safe_browsing/sandboxed_dmg_analyzer_mac.cc",
- "safe_browsing/sandboxed_dmg_analyzer_mac.h",
- "safe_browsing/sandboxed_zip_analyzer.cc",
- "safe_browsing/sandboxed_zip_analyzer.h",
- "safe_browsing/services_delegate_impl.cc",
- "safe_browsing/services_delegate_impl.h",
- "safe_browsing/signature_evaluator_mac.h",
- "safe_browsing/signature_evaluator_mac.mm",
- "safe_browsing/two_phase_uploader.cc",
- "safe_browsing/two_phase_uploader.h",
- "safe_browsing/v4_test_utils.cc",
- "safe_browsing/v4_test_utils.h",
- ]
- deps += [ "//components/safe_browsing_db:safe_browsing_db" ]
- if (is_win) {
- deps += [ "//chrome/browser/safe_browsing/incident_reporting:state_store_data_proto" ]
- }
- } else if (safe_browsing_mode == 2) {
- sources += [
- "loader/safe_browsing_resource_throttle.cc",
- "loader/safe_browsing_resource_throttle.h",
- "safe_browsing/services_delegate_stub.cc",
- "safe_browsing/services_delegate_stub.h",
- ]
- deps += [ "//components/safe_browsing_db:safe_browsing_db_mobile" ]
- }
- }
-
if (enable_hotwording) {
defines += [ "ENABLE_HOTWORDING" ]
}
« no previous file with comments | « no previous file | chrome/browser/extensions/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698