Move SafeBrowsing files from //chrome/browser to a separate target.

chrome/browser/ui/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/chromecast_build.gni")
 import("//build/config/crypto.gni")
 import("//build/config/features.gni")
 import("//build/config/ui.gni")
 import("//build/split_static_library.gni")
 import("//chrome/common/features.gni")
@@ skipping 456 matching lines @@
     "//chrome:resources",
     "//chrome:strings",
     "//chrome/app:chrome_dll_resources",
     "//chrome/app:command_ids",
     "//chrome/app/resources:platform_locale_settings",
     "//chrome/app/theme:chrome_unscaled_resources",
     "//chrome/app/theme:theme_resources",
     "//chrome/browser:resource_prefetch_predictor_proto",
     "//chrome/browser/devtools",
     "//chrome/browser/engagement:mojo_bindings",
+    "//chrome/browser/safe_browsing",
     "//chrome/browser/ui/webui/omnibox:mojo_bindings",

[vakh (use Gerrit instead), 2017/06/19 23:57:25]

Do you know why this dep is needed now when it wasn't needed earlier?

[yzshen1, 2017/06/20 20:48:20]

Do you mean the omnibox:mojo_bindings or safe_browsing?

"omnibox:mojo_bindings" is always there.

"safe_browsing": I think that is because "ui" includes some safe_browsing
headers. We have the following line in //chrome/browser:
allow_circular_includes_from = [ "//chrome/browser/ui" ]
So it is not an issue before.

Now that I moved SB files out of that target, gn check complained unless I added
this dependency.

[vakh (use Gerrit instead), 2017/06/20 21:07:17]

Yes, I meant safe_browsing. Thanks for the clarification.

     "//chrome/browser/ui/webui/usb_internals:mojo_bindings",
     "//chrome/common",
     "//chrome/common:instant_mojom",
     "//chrome/common/net",
     "//chrome/installer/util:with_no_strings",
     "//components/about_ui",
     "//components/app_modal",
     "//components/autofill/content/browser:risk_proto",
     "//components/autofill/core/browser",
     "//components/bookmarks/browser",
@@ skipping 3141 matching lines @@
     deps += [
       "//chrome/test:test_support_ui",
       "//components/zoom",
     ]
   }
 
   if (enable_extensions) {
     deps += [ "//extensions/browser" ]
   }
 }