Fix crash on key events in touchview.

Fix crash on key events in touchview.

BUG=362881
TEST=Key events no longer crash in touchview.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272778

[flackr, 2014-05-23 17:17:05]

Hey, there's a crash because key events are not XI2 events. Is just checking
IsKeyEvent the right thing to do here? PTAL, thanks.

[sadrul, 2014-05-23 17:21:56]

https://codereview.chromium.org/294033016/diff/1/ash/wm/maximize_mode/interna...
File ash/wm/maximize_mode/internal_input_device_list_x11.cc (right):

https://codereview.chromium.org/294033016/diff/1/ash/wm/maximize_mode/interna...
ash/wm/maximize_mode/internal_input_device_list_x11.cc:51: XIDeviceEvent* xiev =
static_cast<XIDeviceEvent*>(
CHECK that event->native_event()->type == GenericEvent instead before this.

[sadrul, 2014-05-23 17:22:34]

https://codereview.chromium.org/294033016/diff/1/ash/wm/maximize_mode/interna...
File ash/wm/maximize_mode/internal_input_device_list_x11.cc (right):

https://codereview.chromium.org/294033016/diff/1/ash/wm/maximize_mode/interna...
ash/wm/maximize_mode/internal_input_device_list_x11.cc:51: XIDeviceEvent* xiev =
static_cast<XIDeviceEvent*>(
On 2014/05/23 17:21:57, sadrul wrote:
> CHECK that event->native_event()->type == GenericEvent instead before this.

s/CHECK/Check/, as in, early return if not GenericEvent.

[flackr, 2014-05-23 17:30:28]

https://codereview.chromium.org/294033016/diff/1/ash/wm/maximize_mode/interna...
File ash/wm/maximize_mode/internal_input_device_list_x11.cc (right):

https://codereview.chromium.org/294033016/diff/1/ash/wm/maximize_mode/interna...
ash/wm/maximize_mode/internal_input_device_list_x11.cc:51: XIDeviceEvent* xiev =
static_cast<XIDeviceEvent*>(
On 2014/05/23 17:22:34, sadrul wrote:
> On 2014/05/23 17:21:57, sadrul wrote:
> > CHECK that event->native_event()->type == GenericEvent instead before this.
> 
> s/CHECK/Check/, as in, early return if not GenericEvent.

Done.

[flackr, 2014-05-23 17:59:24]

Updated issue title to be more specific.

[sadrul, 2014-05-23 18:45:19]

lgtm

[flackr, 2014-05-23 18:46:12]

The CQ bit was checked by flackr@chromium.org

[commit-bot: I haz the power, 2014-05-23 18:47:53]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/flackr@chromium.org/294033016/20001

[commit-bot: I haz the power, 2014-05-23 23:34:56]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-24 02:32:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-24 02:32:02]

Try jobs failed on following builders:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[flackr, 2014-05-25 02:11:33]

The CQ bit was checked by flackr@chromium.org

[commit-bot: I haz the power, 2014-05-25 02:11:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/flackr@chromium.org/294033016/20001

[commit-bot: I haz the power, 2014-05-26 04:04:06]

Change committed as 272778