Added --isolate-file-path option to android test_runner.

Added --isolate-file-path option to android test_runner.

Currently, .isolate file list is hard-coded in
build/android/pylib/gtest/setup.py so for downstream to
provide .isolate file, we need to modify the upstream setup.py
file. So add --isolate-file-path option so that downstream
can provide their own .isolate file if they want.

BUG=368034
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272137

[Kibeom Kim (inactive), 2014-05-20 23:22:12]

This is not for review(yet) and uploaded to ask a question.

I needed to add a test to clank_unittests in downstream, which requires some
.pak files and icudtl.dat, but currently .isolate files are specified in
upstream so inserting clank_unittests location doesn't seem correct.

Could anyone advise on what would be a correct way of fixing it?

[M-A Ruel, 2014-05-21 00:41:07]

On 2014/05/20 23:22:12, Kibeom Kim wrote:
> This is not for review(yet) and uploaded to ask a question.
> 
> I needed to add a test to clank_unittests in downstream, which requires some
> .pak files and icudtl.dat, but currently .isolate files are specified in
> upstream so inserting clank_unittests location doesn't seem correct.
> 
> Could anyone advise on what would be a correct way of fixing it?

As long as the clank_unittests_run target is only defined when downstream is
checked out, it's fine. The mere presence of clank_unittests.isolate has no
effect on its own, unless the corresponding gyp target is conditionally enabled.

[Kibeom Kim (inactive), 2014-05-21 01:11:53]

On 2014/05/21 00:41:07, M-A Ruel wrote:
> On 2014/05/20 23:22:12, Kibeom Kim wrote:
> > This is not for review(yet) and uploaded to ask a question.
> > 
> > I needed to add a test to clank_unittests in downstream, which requires some
> > .pak files and icudtl.dat, but currently .isolate files are specified in
> > upstream so inserting clank_unittests location doesn't seem correct.
> > 
> > Could anyone advise on what would be a correct way of fixing it?
> 
> As long as the clank_unittests_run target is only defined when downstream is
> checked out, it's fine. The mere presence of clank_unittests.isolate has no
> effect on its own, unless the corresponding gyp target is conditionally
enabled.

I thought putting downstream detail on the upstream is discouraged, if not
prohibited. So I was thinking something like passing an additional argument to
specify the path, and use it only on downstream. But if this is acceptable, I'll
go with this. I think it shouldn't be too bad in practice, considering this is
for testing.

[M-A Ruel, 2014-05-21 01:36:11]

On 2014/05/21 01:11:53, Kibeom Kim wrote:
> On 2014/05/21 00:41:07, M-A Ruel wrote:
> > On 2014/05/20 23:22:12, Kibeom Kim wrote:
> > > This is not for review(yet) and uploaded to ask a question.
> > > 
> > > I needed to add a test to clank_unittests in downstream, which requires
some
> > > .pak files and icudtl.dat, but currently .isolate files are specified in
> > > upstream so inserting clank_unittests location doesn't seem correct.
> > > 
> > > Could anyone advise on what would be a correct way of fixing it?
> > 
> > As long as the clank_unittests_run target is only defined when downstream is
> > checked out, it's fine. The mere presence of clank_unittests.isolate has no
> > effect on its own, unless the corresponding gyp target is conditionally
> enabled.
> 
> I thought putting downstream detail on the upstream is discouraged, if not
> prohibited. So I was thinking something like passing an additional argument to
> specify the path, and use it only on downstream. But if this is acceptable,
I'll
> go with this. I think it shouldn't be too bad in practice, considering this is
> for testing.

Oh, sorry for the misleading comment above. You can and probably should put the
isolate file downstream. I mean, the clank_unittests_run should be defined just
beside clank_unittests and the .isolate should be beside the .gyp/.gypi files.

[Kibeom Kim (inactive), 2014-05-21 01:40:07]

On 2014/05/21 01:36:11, M-A Ruel wrote:
>
> Oh, sorry for the misleading comment above. You can and probably should put
the
> isolate file downstream. I mean, the clank_unittests_run should be defined
just
> beside clank_unittests and the .isolate should be beside the .gyp/.gypi files.

Actually my comment was misleading... I'll put the .isolate on downstream, but
what I wasn't sure is if putting the downstream file path string
'clank/native/framework/clank_unittests.isolate', on upstream is OK or not.

[M-A Ruel, 2014-05-21 01:50:32]

On 2014/05/21 01:40:07, Kibeom Kim wrote:
> On 2014/05/21 01:36:11, M-A Ruel wrote:
> >
> > Oh, sorry for the misleading comment above. You can and probably should put
> the
> > isolate file downstream. I mean, the clank_unittests_run should be defined
> just
> > beside clank_unittests and the .isolate should be beside the .gyp/.gypi
files.
> 
> Actually my comment was misleading... I'll put the .isolate on downstream, but
> what I wasn't sure is if putting the downstream file path string
> 'clank/native/framework/clank_unittests.isolate', on upstream is OK or not.

Well, I assume this script doesn't work at all on an open source checkout? If
so, it doesn't matter then.

lgtm

[bulach, 2014-05-21 12:09:12]

yeah, we shouldn't reference downstream from here.
please, add an option at
https://code.google.com/p/chromium/codesearch#chromium/src/build/android/test...

and then downstream buildbot steps would inject this option.

[Kibeom Kim (inactive), 2014-05-21 19:58:09]

ptal

[bulach, 2014-05-21 20:08:34]

lgtm, thanks! please wait for jbudorick, he's the actual owner these days :)

[jbudorick, 2014-05-21 20:40:06]

lgtm

[Kibeom Kim (inactive), 2014-05-21 20:41:29]

The CQ bit was checked by kkimlabs@chromium.org

[commit-bot: I haz the power, 2014-05-21 20:43:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/294033003/20001

[commit-bot: I haz the power, 2014-05-22 08:18:51]

Change committed as 272137