Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Unified Diff: chrome/browser/chromeos/login/kiosk_browsertest.cc

Issue 294033002: Multi-profile flag cleanup. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Return --test-type flag back to profile_manager_unittest.cc Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/kiosk_browsertest.cc
diff --git a/chrome/browser/chromeos/login/kiosk_browsertest.cc b/chrome/browser/chromeos/login/kiosk_browsertest.cc
index 13f35d1c7db3c7d278bef66b1c14c614f4330240..d0d4c5a8c4088a61fbb9dee186591fb216e332f7 100644
--- a/chrome/browser/chromeos/login/kiosk_browsertest.cc
+++ b/chrome/browser/chromeos/login/kiosk_browsertest.cc
@@ -38,7 +38,6 @@
#include "chrome/browser/ui/webui/chromeos/login/kiosk_app_menu_handler.h"
#include "chrome/common/chrome_constants.h"
#include "chrome/common/chrome_paths.h"
-#include "chrome/common/chrome_switches.h"
#include "chrome/common/pref_names.h"
#include "chromeos/chromeos_switches.h"
#include "chromeos/dbus/cryptohome_client.h"
@@ -870,8 +869,7 @@ IN_PROC_BROWSER_TEST_F(KioskTest, KioskEnableAfter2ndSigninScreen) {
content::NotificationService::AllSources()).Wait();
}
-class KioskUpdateTest : public KioskTest,
- public testing::WithParamInterface<bool> {
+class KioskUpdateTest : public KioskTest {
public:
KioskUpdateTest() {}
virtual ~KioskUpdateTest() {}
@@ -880,10 +878,7 @@ class KioskUpdateTest : public KioskTest,
virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE {
// Needs background networking so that ExtensionDownloader works.
needs_background_networking_ = true;
-
KioskTest::SetUpCommandLine(command_line);
- if (GetParam())
- command_line->AppendSwitch(::switches::kMultiProfiles);
}
virtual void SetUpOnMainThread() OVERRIDE {
@@ -895,7 +890,7 @@ class KioskUpdateTest : public KioskTest,
DISALLOW_COPY_AND_ASSIGN(KioskUpdateTest);
};
-IN_PROC_BROWSER_TEST_P(KioskUpdateTest, LaunchOfflineEnabledAppNoNetwork) {
+IN_PROC_BROWSER_TEST_F(KioskUpdateTest, LaunchOfflineEnabledAppNoNetwork) {
set_test_app_id(kTestOfflineEnabledKioskApp);
PrepareAppLaunch();
@@ -906,7 +901,7 @@ IN_PROC_BROWSER_TEST_P(KioskUpdateTest, LaunchOfflineEnabledAppNoNetwork) {
WaitForAppLaunchSuccess();
}
-IN_PROC_BROWSER_TEST_P(KioskUpdateTest, LaunchOfflineEnabledAppNoUpdate) {
+IN_PROC_BROWSER_TEST_F(KioskUpdateTest, LaunchOfflineEnabledAppNoUpdate) {
set_test_app_id(kTestOfflineEnabledKioskApp);
fake_cws()->SetNoUpdate(test_app_id());
@@ -921,7 +916,7 @@ IN_PROC_BROWSER_TEST_P(KioskUpdateTest, LaunchOfflineEnabledAppNoUpdate) {
EXPECT_EQ("1.0.0", GetInstalledAppVersion().GetString());
}
-IN_PROC_BROWSER_TEST_P(KioskUpdateTest, LaunchOfflineEnabledAppHasUpdate) {
+IN_PROC_BROWSER_TEST_F(KioskUpdateTest, LaunchOfflineEnabledAppHasUpdate) {
set_test_app_id(kTestOfflineEnabledKioskApp);
fake_cws()->SetUpdateCrx(
@@ -937,7 +932,7 @@ IN_PROC_BROWSER_TEST_P(KioskUpdateTest, LaunchOfflineEnabledAppHasUpdate) {
EXPECT_EQ("2.0.0", GetInstalledAppVersion().GetString());
}
-IN_PROC_BROWSER_TEST_P(KioskUpdateTest, PermissionChange) {
+IN_PROC_BROWSER_TEST_F(KioskUpdateTest, PermissionChange) {
set_test_app_id(kTestOfflineEnabledKioskApp);
fake_cws()->SetUpdateCrx(
@@ -955,7 +950,7 @@ IN_PROC_BROWSER_TEST_P(KioskUpdateTest, PermissionChange) {
EXPECT_EQ("2.0.0", GetInstalledAppVersion().GetString());
}
-IN_PROC_BROWSER_TEST_P(KioskUpdateTest, PRE_PreserveLocalData) {
+IN_PROC_BROWSER_TEST_F(KioskUpdateTest, PRE_PreserveLocalData) {
// Installs v1 app and writes some local data.
set_test_app_id(kTestLocalFsKioskApp);
@@ -965,7 +960,7 @@ IN_PROC_BROWSER_TEST_P(KioskUpdateTest, PRE_PreserveLocalData) {
ASSERT_TRUE(catcher.GetNextResult()) << catcher.message();
}
-IN_PROC_BROWSER_TEST_P(KioskUpdateTest, PreserveLocalData) {
+IN_PROC_BROWSER_TEST_F(KioskUpdateTest, PreserveLocalData) {
// Update existing v1 app installed in PRE_PreserveLocalData to v2
// that reads and verifies the local data.
set_test_app_id(kTestLocalFsKioskApp);
@@ -983,11 +978,6 @@ IN_PROC_BROWSER_TEST_P(KioskUpdateTest, PreserveLocalData) {
ASSERT_TRUE(catcher.GetNextResult()) << catcher.message();
}
-// TODO(xiyuan): Remove this after multi profile is turned on by default.
-INSTANTIATE_TEST_CASE_P(KioskUpdateTestInstantiation,
- KioskUpdateTest,
- testing::Bool());
-
class KioskEnterpriseTest : public KioskTest {
protected:
KioskEnterpriseTest() {}

Powered by Google App Engine
This is Rietveld 408576698