Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 294033002: Multi-profile flag cleanup. (Closed)

Created:
6 years, 7 months ago by Nikita (slow)
Modified:
6 years, 7 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, extensions-reviews_chromium.org, sadrul, nkostylev+watch_chromium.org, Ilya Sherman, yoshiki+watch_chromium.org, asvitkine+watch_chromium.org, rginda+watch_chromium.org, ben+ash_chromium.org, oshima+watch_chromium.org, kalyank, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, jar (doing other things)
Visibility:
Public.

Description

Multi-profile flag cleanup. Rebased version of https://codereview.chromium.org/287083003/ BUG=364604, 351655 TEST=existing tests TBR=sky,zelidrag Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271720

Patch Set 1 #

Patch Set 2 : Return --test-type flag back to profile_manager_unittest.cc #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -278 lines) Patch
M chrome/browser/chromeos/extensions/wallpaper_private_api_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/file_manager/file_manager_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/crash_restore_browsertest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller_browsertest.cc View 14 chunks +13 lines, -25 lines 0 comments Download
M chrome/browser/chromeos/login/kiosk_browsertest.cc View 10 chunks +7 lines, -17 lines 0 comments Download
M chrome/browser/chromeos/login/login_manager_test.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/ui/user_adding_screen_browsertest.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_browsertest.cc View 27 chunks +23 lines, -45 lines 0 comments Download
M chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_policy_browsertest.cc View 11 chunks +10 lines, -19 lines 0 comments Download
M chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/preferences_browsertest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/profiles/profile_helper_browsertest.cc View 5 chunks +4 lines, -15 lines 0 comments Download
M chrome/browser/chromeos/profiles/profile_list_chromeos_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/networking_private/networking_private_apitest.cc View 11 chunks +26 lines, -34 lines 0 comments Download
M chrome/browser/metrics/metrics_log_unittest.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/notifications/login_state_notification_blocker_chromeos_browsertest.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/notifications/message_center_settings_controller_unittest.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 1 1 chunk +1 line, -0 lines 2 comments Download
M chrome/browser/profiles/profile_manager_unittest.cc View 1 4 chunks +9 lines, -18 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_context_menu_chromeos_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_command_controller_unittest.cc View 4 chunks +0 lines, -24 lines 0 comments Download
M chrome/browser/ui/settings_window_manager_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/startup/session_crashed_infobar_delegate_unittest.cc View 3 chunks +0 lines, -28 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/shared_options_browsertest.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Nikita (slow)
The CQ bit was checked by nkostylev@chromium.org
6 years, 7 months ago (2014-05-20 11:33:02 UTC) #1
Nikita (slow)
6 years, 7 months ago (2014-05-20 11:33:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/294033002/1
6 years, 7 months ago (2014-05-20 11:33:47 UTC) #3
Nikita (slow)
The CQ bit was checked by nkostylev@chromium.org
6 years, 7 months ago (2014-05-20 13:25:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/294033002/20001
6 years, 7 months ago (2014-05-20 13:26:30 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-20 17:09:45 UTC) #6
commit-bot: I haz the power
Change committed as 271720
6 years, 7 months ago (2014-05-20 19:12:32 UTC) #7
dzhioev (left Google)
https://codereview.chromium.org/294033002/diff/20001/chrome/browser/profiles/profile_manager.cc File chrome/browser/profiles/profile_manager.cc (right): https://codereview.chromium.org/294033002/diff/20001/chrome/browser/profiles/profile_manager.cc#newcode805 chrome/browser/profiles/profile_manager.cc:805: LOG(ERROR) << ">>>>>>>> " << command_line.GetCommandLineString(); Did you commit ...
6 years, 7 months ago (2014-05-21 19:13:00 UTC) #8
Nikita (slow)
6 years, 7 months ago (2014-05-26 08:06:37 UTC) #9
Message was sent while issue was closed. 
https://codereview.chromium.org/294033002/diff/20001/chrome/browser/profiles/...
File chrome/browser/profiles/profile_manager.cc (right):

https://codereview.chromium.org/294033002/diff/20001/chrome/browser/profiles/...
chrome/browser/profiles/profile_manager.cc:805: LOG(ERROR) << ">>>>>>>> " <<
command_line.GetCommandLineString();
On 2014/05/21 19:13:01, dzhioev wrote:
> Did you commit this line by mistake?

Thanks, removed in https://codereview.chromium.org/297393002/.

Powered by Google App Engine
This is Rietveld 408576698