Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2940323002: [kernel] Don't emit field initializers in a redirecting constructor (Closed)

Created:
3 years, 6 months ago by jensj
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[kernel] Don't emit field initializers in a redirecting constructor BUG= R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/5472eb78318da70f9a4270537cf8d5e805ed1711

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -5 lines) Patch
M runtime/vm/kernel_binary_flowgraph.cc View 2 chunks +21 lines, -3 lines 1 comment Download
M tests/language/language_kernel.status View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
jensj
This assumes that we in kernel - when having a redirecting constructor - only have ...
3 years, 6 months ago (2017-06-16 10:58:13 UTC) #2
Vyacheslav Egorov (Google)
lgtm https://codereview.chromium.org/2940323002/diff/1/runtime/vm/kernel_binary_flowgraph.cc File runtime/vm/kernel_binary_flowgraph.cc (right): https://codereview.chromium.org/2940323002/diff/1/runtime/vm/kernel_binary_flowgraph.cc#newcode3022 runtime/vm/kernel_binary_flowgraph.cc:3022: NameIndex canonical_target = ASSERT(list_length == 1) here
3 years, 6 months ago (2017-06-16 11:14:29 UTC) #3
jensj
3 years, 6 months ago (2017-06-20 11:54:33 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
5472eb78318da70f9a4270537cf8d5e805ed1711 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698