Issue 294031: Added missing reset of top_blurb visibility...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 294031: Added missing reset of top_blurb visibility... (Closed)

Created:
11 years, 2 months ago by Bruno

Modified:
9 years, 7 months ago

Reviewers:
tim (not reviewing)

CC:
chromium-reviews_googlegroups.com, ncarter (slow), ben+cc_chromium.org, tim (not reviewing), idana

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Added missing reset of top_blurb visibility Changed setBlurbError to reuse code Also removed all trailing spaces BUG=22473 TEST=See repro steps in bug

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+115 lines, -116 lines)			Patch
	M	chrome/browser/sync/resources/gaia_login.html	View	1	13 chunks	+115 lines, -116 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Bruno

On 2009/10/20 23:50:26, Bruno wrote: > Hi Tim, do you mind reviewing this one? Bruno

11 years, 1 month ago (2009-11-10 17:17:51 UTC) #2

Bruno

On 2009/10/20 23:50:26, Bruno wrote: Hi Tim, do you mind reviewing this one? Bruno http://codereview.chromium.org/294031

11 years, 1 month ago (2009-11-10 17:18:09 UTC) #3

Bruno

11 years ago (2009-12-17 22:14:00 UTC) #6

On 2009/11/11 18:40:27, timsteele wrote:
> LGTM
> 
> http://codereview.chromium.org/294031

Tim, I updated the patch so it applies cleanly again.

Bruno

Expand Messages | Collapse Messages