runtime/vm/kernel_binary.cc - Issue 2940283002: [kernel] Fix assert message.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/kernel_binary.cc

Issue 2940283002: [kernel] Fix assert message. (Closed)

Patch Set: Address comments Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/kernel_binary.cc

diff --git a/runtime/vm/kernel_binary.cc b/runtime/vm/kernel_binary.cc

index 690224221a32c6004fa61c4083e413d42539dd96..4757791fad23ef7cb4205e623b7e2e18bfc83688 100644

--- a/runtime/vm/kernel_binary.cc

+++ b/runtime/vm/kernel_binary.cc

@@ -1320,6 +1320,8 @@ AssertStatement* AssertStatement::ReadFrom(Reader* reader) {

AssertStatement* stmt = new AssertStatement();

stmt->kernel_offset_ = reader->offset() - 1; // -1 to include tag byte.

stmt->condition_ = Expression::ReadFrom(reader);

+ reader->ReadPosition(); // condition start offset.

+ reader->ReadPosition(); // condition end offset.

stmt->message_ = reader->ReadOptional<Expression>();

stmt->can_stream_ = stmt->condition_->can_stream() &&

« no previous file with comments | « runtime/lib/errors_patch.dart ('k') | runtime/vm/kernel_binary_flowgraph.cc » ('j') | no next file with comments »