Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 294023015: Hook up request interceptors in AndroidWebView code. (Closed)

Created:
6 years, 7 months ago by mmenke
Modified:
6 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, android-webview-reviews_chromium.org
Visibility:
Public.

Description

Hook up request interceptors in AndroidWebView code. Request interceptors are the new way to handle intercepting URL requests, to be used by ServiceWorkers and AppCache. This CL hooks them up to the URLRequestContext in AndroidWebview. BUG=350286 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274586

Patch Set 1 #

Patch Set 2 : Merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -29 lines) Patch
M android_webview/browser/aw_browser_context.h View 1 1 chunk +4 lines, -2 lines 0 comments Download
M android_webview/browser/aw_browser_context.cc View 1 2 chunks +6 lines, -3 lines 0 comments Download
M android_webview/browser/aw_content_browser_client.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M android_webview/browser/net/aw_url_request_context_getter.h View 1 2 chunks +11 lines, -8 lines 0 comments Download
M android_webview/browser/net/aw_url_request_context_getter.cc View 1 5 chunks +11 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mmenke
This shouldn't have any immediate impact, but ServiceWorkers will be hooked up this way, and ...
6 years, 6 months ago (2014-06-02 21:14:41 UTC) #1
mkosiba (inactive)
lgtm
6 years, 6 months ago (2014-06-03 08:06:01 UTC) #2
pauljensen
lgtm
6 years, 6 months ago (2014-06-03 10:45:26 UTC) #3
mmenke
The CQ bit was checked by mmenke@chromium.org
6 years, 6 months ago (2014-06-03 12:41:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/294023015/60001
6 years, 6 months ago (2014-06-03 12:42:33 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-03 16:40:02 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 19:13:36 UTC) #7
Message was sent while issue was closed.
Change committed as 274586

Powered by Google App Engine
This is Rietveld 408576698