Chromium Code Reviews Chromium Code Reviews
Issue
294023012:
Use a separate NSView to draw browser composited content (Closed)
DescriptionUse a separate NSView to draw browser composited content
Prior to this, the RenderWidgetHostViewMac was responsible for drawing
(with its NSViews and CALayers) the contents coming from the renderer
compositor or the browser compositor. This was was getting too messy
(lots of state was shared unintentionally).
This create a BrowserCompositorViewMac sub-NSView of the
RenderWidgetHostViewMac, which is responsible for drawing delegated
renderer content coming from the browser.
This class still uses the SoftwareLayer and CompositingIOSurfaceLayer
classes used to draw content from renderer. In order to make this clean,
cut the dependencies from the CompositingIOSurfaceLayer to the
RenderWidgetHostViewMac, and hide all needed communication behind a
CompositingIOSurfaceLayerClient interface (which is likely to be needed
by the BrowserCompositorViewMac).
It would seem more reasonable to have BrowserCompositorViewMac live in
the ui namespace and directories, but that is not an option yet, because
it needs to share so much code with RenderWidgetHostViewMac. Once we
switch to using only a delegated renderer, we can move all of this code
over to ui.
Also, start replacing instances of "composited" with "accelerated". It
used to be that these were synonyms, but they are not anymore --
"composited" can be either "accelerated" or "software".
BUG=314190
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272469
Patch Set 1 #Patch Set 2 : Comments, clean-u #Messages
Total messages: 7 (0 generated)
|
