Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Unified Diff: third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node_data.h

Issue 2940153002: [LayoutNG] Implement more text-align values and BiDi base direction (Closed)
Patch Set: eae review Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node_data.h
diff --git a/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node_data.h b/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node_data.h
index 1989c8ac7ef134c7fb659b7246be5f47dcaef5d9..2550071b5ca0a6515584f9fa8007ca12ec7f5862 100644
--- a/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node_data.h
+++ b/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node_data.h
@@ -16,6 +16,13 @@ class LayoutBox;
// Data which is required for inline nodes.
struct CORE_EXPORT NGInlineNodeData {
private:
+ TextDirection BaseDirection() const {
+ return static_cast<TextDirection>(base_direction_);
+ }
+ void SetBaseDirection(TextDirection direction) {
+ base_direction_ = static_cast<unsigned>(direction);
+ }
+
friend class NGInlineNode;
friend class NGInlineNodeForTest;
@@ -31,9 +38,8 @@ struct CORE_EXPORT NGInlineNodeData {
// start_inline_ must always be reset within the constructor of NGInlineNode.
LayoutObject* start_inline_;
- // TODO(kojii): This should move to somewhere else when we move PrepareLayout
- // to the correct place.
- bool is_bidi_enabled_ = false;
+ unsigned is_bidi_enabled_ : 1;
+ unsigned base_direction_ : 1; // TextDirection
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698