[Extensions] Update DeclarativeApiTest.DeclarativeApi

chrome/test/data/extensions/api_test/declarative/api/background.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var declarative = chrome.declarative;
 
 var RequestMatcher = chrome.declarativeWebRequest.RequestMatcher;
 var CancelRequest = chrome.declarativeWebRequest.CancelRequest;
 var RedirectRequest = chrome.declarativeWebRequest.RedirectRequest;
 var SetRequestHeader = chrome.declarativeWebRequest.SetRequestHeader;
@@ skipping 62 matching lines @@
   function testInvalidAddRules() {
     try {
       testEvent.addRules();
       chrome.test.fail();
     } catch(e) {
       chrome.test.succeed();
     }
   },
   function testInvalidGetRules() {
     try {
-      testEvent.getRules(function() {});
+      testEvent.getRules(1, function() {});
       chrome.test.fail();
     } catch(e) {
       chrome.test.succeed();
     }
   },
   function testInvalidRemoveRules() {
     try {
-      testEvent.removeRules(function() {});
+      testEvent.removeRules(1, function() {});
       chrome.test.fail();
     } catch(e) {
       chrome.test.succeed();
     }
   },
   // Add adding two simple rules and check that their optional fields are set
   // correctly in the call back function.
   function testAddRules() {
     var callback = function(rules) {
       chrome.test.assertNoLastError();
       chrome.test.assertEq(2, rules.length);
       // API should have generated id and priority fields.
       chrome.test.assertTrue("id" in rules[0]);
       chrome.test.assertEq([outputRule0, outputRule1], rules);
       chrome.test.succeed();
     };
     testEvent.addRules([inputRule0, inputRule1], callback);
   },
   // Check that getRules() returns all rules if no filter is passed.
   function testGetRules() {
     var callback = function(rules) {
       chrome.test.assertNoLastError();
       // We are not given any gurantee on the order in which rules are returned.
       chrome.test.assertTrue(
-        chrome.test.checkDeepEq([outputRule0, outputRule1], rules) ||
-        chrome.test.checkDeepEq([outputRule1, outputRule0], rules));
+          chrome.test.checkDeepEq([outputRule0, outputRule1], rules) ||
+          chrome.test.checkDeepEq([outputRule1, outputRule0], rules));
       chrome.test.succeed();
     }
     testEvent.getRules(null, callback);
   },
   // Check that getRules() returns all rules if no filter is passed.
   function testGetRules2() {
     var callback = function(rules) {
       chrome.test.assertNoLastError();
       // We are not given any gurantee on the order in which rules are returned.
       chrome.test.assertTrue(
-        chrome.test.checkDeepEq([outputRule0, outputRule1], rules) ||
-        chrome.test.checkDeepEq([outputRule1, outputRule0], rules));
+          chrome.test.checkDeepEq([outputRule0, outputRule1], rules) ||
+          chrome.test.checkDeepEq([outputRule1, outputRule0], rules));
       chrome.test.succeed();
     }
     testEvent.getRules(undefined, callback);
   },
   // Check that getRules() returns no rules if empty filter is passed.
   function testGetRules3() {
     var callback = function(rules) {
       chrome.test.assertNoLastError();
-      // We are not given any gurantee on the order in which rules are returned.
       chrome.test.assertEq([], rules);
       chrome.test.succeed();
     }
     testEvent.getRules([], callback);
   },
-  // Check that getRules() returns all rules if rules are filtered by ID.
+  // TODO(devlin): The documentation for event.getRules() states that the
+  // filter parameter is optional. However, with JS bindings, we throw an error
+  // if it's omitted. This is fixed with native bindings.
+  // Check that getRules() returns all rules if the filter is omitted.
+  // function testGetRules4() {
+  //   var callback = function(rules) {
+  //     chrome.test.assertNoLastError();
+  //     // We are not given any gurantee on the order in which rules are
+  //     // returned.
+  //     chrome.test.assertTrue(
+  //         chrome.test.checkDeepEq([outputRule0, outputRule1], rules) ||
+  //         chrome.test.checkDeepEq([outputRule1, outputRule0], rules));
+  //     chrome.test.succeed();
+  //   }
+  //   testEvent.getRules(callback);
+  // },
+  // Check that getRules() returns matching rules if rules are filtered by ID.
   function testSelectiveGetRules() {
     var callback = function(rules) {
       chrome.test.assertNoLastError();
       chrome.test.assertEq([outputRule1], rules);
       chrome.test.succeed();
     }
     testEvent.getRules(["my_rule_id"], callback);
   },
   // Check that we can remove individual rules.
   function testSelectiveRemoveRules() {
@@ skipping 75 matching lines @@
   // on page unload.
   function testAddRules() {
     var callback = function(rules) {
       chrome.test.assertNoLastError();
       chrome.test.assertEq(1, rules.length);
       chrome.test.succeed();
     };
     testEvent.addRules([inputRule0], callback);
   },
   ]);