Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: chrome/browser/previews/previews_infobar_delegate.h

Issue 2940083003: Add timestamp to infobar for stale Previews (Closed)
Patch Set: add GetMessageText comment Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/previews/previews_infobar_delegate.h
diff --git a/chrome/browser/previews/previews_infobar_delegate.h b/chrome/browser/previews/previews_infobar_delegate.h
index 0979c07e2b7efef2d24c351b166d14eea62abf51..47245eace9816691ce6460ebb2aea829b7e751bf 100644
--- a/chrome/browser/previews/previews_infobar_delegate.h
+++ b/chrome/browser/previews/previews_infobar_delegate.h
@@ -7,6 +7,7 @@
#include "base/callback.h"
#include "base/strings/string16.h"
+#include "base/time/time.h"
#include "components/infobars/core/confirm_infobar_delegate.h"
#include "components/previews/core/previews_experiments.h"
@@ -41,10 +42,12 @@ class PreviewsInfoBarDelegate : public ConfirmInfoBarDelegate {
static void Create(
content::WebContents* web_contents,
previews::PreviewsType previews_type,
+ base::Time previews_freshness,
bool is_data_saver_user,
const OnDismissPreviewsInfobarCallback& on_dismiss_callback);
// ConfirmInfoBarDelegate overrides:
+ int GetIconId() const override;
base::string16 GetMessageText() const override;
base::string16 GetLinkText() const override;
@@ -54,18 +57,21 @@ class PreviewsInfoBarDelegate : public ConfirmInfoBarDelegate {
PreviewsInfoBarDelegate(
content::WebContents* web_contents,
previews::PreviewsType previews_type,
+ base::Time previews_freshness,
bool is_data_saver_user,
const OnDismissPreviewsInfobarCallback& on_dismiss_callback);
// ConfirmInfoBarDelegate overrides:
infobars::InfoBarDelegate::InfoBarIdentifier GetIdentifier() const override;
- int GetIconId() const override;
bool ShouldExpire(const NavigationDetails& details) const override;
void InfoBarDismissed() override;
int GetButtons() const override;
bool LinkClicked(WindowOpenDisposition disposition) override;
previews::PreviewsType previews_type_;
+ // The time at which the preview associated with this infobar was created. A
+ // value of zero means that the creation time is unknown.
+ const base::Time previews_freshness_;
mutable PreviewsInfoBarAction infobar_dismissed_action_;
const base::string16 message_text_;

Powered by Google App Engine
This is Rietveld 408576698