Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 2940073002: Update language_kernel.status for closed issue. (Closed)

Created:
3 years, 6 months ago by jensj
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M tests/language/language_kernel.status View 1 chunk +0 lines, -2 lines 1 comment Download

Messages

Total messages: 7 (3 generated)
jensj
https://github.com/dart-lang/sdk/issues/28312 was closed some months ago, and the test (now) runs in 4 seconds on ...
3 years, 6 months ago (2017-06-15 11:33:12 UTC) #2
Vyacheslav Egorov (Google)
lgtm
3 years, 6 months ago (2017-06-15 11:40:07 UTC) #3
jensj
Committed patchset #1 (id:1) manually as dc72d9c34ef71e0516bd75a9d8b6728d1a660a1f (presubmit successful).
3 years, 6 months ago (2017-06-15 11:41:20 UTC) #5
ahe
3 years, 6 months ago (2017-06-15 12:02:21 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/2940073002/diff/1/tests/language/language_ker...
File tests/language/language_kernel.status (right):

https://codereview.chromium.org/2940073002/diff/1/tests/language/language_ker...
tests/language/language_kernel.status:122:
mixin_forwarding_constructor4_test/03: MissingCompileTimeError # KernelVM bug:
Issue 15101
This is odd. This is a bug in Fasta, I'll investigate.

Powered by Google App Engine
This is Rietveld 408576698