Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Unified Diff: pkg/compiler/lib/src/inferrer/locals_handler.dart

Issue 2940023004: fix inferrer bug (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/inferrer/locals_handler.dart
diff --git a/pkg/compiler/lib/src/inferrer/locals_handler.dart b/pkg/compiler/lib/src/inferrer/locals_handler.dart
index e0900e9d2be767414dc6df7442e722931cf7bf8a..42d50f9f01dbd2b80430f9cac6ebd50fc1bdcbae 100644
--- a/pkg/compiler/lib/src/inferrer/locals_handler.dart
+++ b/pkg/compiler/lib/src/inferrer/locals_handler.dart
@@ -190,12 +190,11 @@ class ArgumentsTypes extends IterableMixin<TypeInformation> {
for (int i = 0; i < positional.length; i++) {
if (positional[i] != other.positional[i]) return false;
}
+ var result = true;
named.forEach((name, type) {
- // Issue 29885.
- // ignore: RETURN_OF_INVALID_TYPE
- if (other.named[name] != type) return false;
+ if (other.named[name] != type) result = false;
});
- return true;
+ return result;
}
int get hashCode => throw new UnsupportedError('ArgumentsTypes.hashCode');
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698