chrome/common/profiling/memlog_sender_pipe.h - Issue 2940003002: Add pipe implementation for OOP memory logging

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/profiling/memlog_sender_pipe.h

Issue 2940003002: Add pipe implementation for OOP memory logging (Closed)

Patch Set: Explicit Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_COMMON_PROFILING_MEMLOG_SENDER_PIPE_H_

	6 #define CHROME_COMMON_PROFILING_MEMLOG_SENDER_PIPE_H_

	7

	8 #include "build/build_config.h"

	9

	10 #if defined(OS_WIN)
	Boris Vidolov 2017/06/15 21:50:59 Cam we avoid the conditional compilation by using Cam we avoid the conditional compilation by using the same pipe header and vary only the .cc file? brettw 2017/06/15 22:12:21 This is similar to a previous iteration I did that Show quoted text On 2017/06/15 21:50:59, Boris Vidolov wrote: > Cam we avoid the conditional compilation by using the same pipe header and vary > only the .cc file? This is similar to a previous iteration I did that I wasn't very happy with. As we discussed in Slack, it's hard to make decisions here without seeing what the other implementations look like. We can tweak as those come in.
	11 #include "chrome/common/profiling/memlog_sender_pipe_win.h"

	12 #endif

	13

	14 #endif // CHROME_COMMON_PROFILING_MEMLOG_SENDER_PIPE_H_

OLD	NEW