components/viz/common/BUILD.gn - Issue 2939953004: viz: Move some code into //components/viz/common.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/viz/common/BUILD.gn

Issue 2939953004: viz: Move some code into //components/viz/common. (Closed)

Patch Set: . Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright 2017 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 source_set("common") {

	6 sources = [

	7 "server_gpu_memory_buffer_manager.cc",

	8 "server_gpu_memory_buffer_manager.h",

	9 ]

	10

	11 deps = [

	12 "//gpu/ipc/client",

	13 ]

	14

	15 public_deps = [

	16 "//gpu/command_buffer/client",

	17 "//gpu/ipc/common",

	18 "//gpu/ipc/host",

	19 "//services/ui/gpu/interfaces",
	danakj 2017/06/14 22:57:57 does this need to be a public dep for a forward de does this need to be a public dep for a forward declare? i'm not sure what the other deps are for, can you make sure they make sense as public deps too for the whole directory? sadrul 2017/06/14 23:18:33 I moved gpu/ipc/common into deps. But the rest are Show quoted text On 2017/06/14 22:57:57, danakj wrote: > does this need to be a public dep for a forward declare? > > i'm not sure what the other deps are for, can you make sure they make sense as > public deps too for the whole directory? I moved gpu/ipc/common into deps. But the rest are exposed in the header file, so it would be better to leave them in public deps. For mojom, the user of ServerGMBManager has to inject in the mojom impl. So it feels reasonable to me to make it a public dep too. I am not really sure if all of these deps will apply equally to all code in here. We could have sub-components here too, but maybe we can wait until this grows a bit to see how/whether we can organize it better? danakj 2017/06/15 15:08:58 Similar to the header, the user of this has to con Show quoted text On 2017/06/14 23:18:33, sadrul wrote: > On 2017/06/14 22:57:57, danakj wrote: > > does this need to be a public dep for a forward declare? > > > > i'm not sure what the other deps are for, can you make sure they make sense as > > public deps too for the whole directory? > > I moved gpu/ipc/common into deps. But the rest are exposed in the header file, > so it would be better to leave them in public deps. > > For mojom, the user of ServerGMBManager has to inject in the mojom impl. So it > feels reasonable to me to make it a public dep too. > > I am not really sure if all of these deps will apply equally to all code in > here. We could have sub-components here too, but maybe we can wait until this > grows a bit to see how/whether we can organize it better? Similar to the header, the user of this has to construct the mojom types and pass them in, so it needs to depend on the mojom targets in order to call the constructors. That dep does not need to come from here.
	20 "//ui/gfx",

	21 ]

	22 }

OLD	NEW

« no previous file with comments | « no previous file | components/viz/common/DEPS » ('j') | components/viz/common/server_gpu_memory_buffer_manager.h » ('J')