Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2939943005: Fix unittests (Closed)

Created:
3 years, 6 months ago by Johnni Winther
Modified:
3 years, 6 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -35 lines) Patch
M pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/annotated_code_helper.dart View 3 chunks +46 lines, -32 lines 0 comments Download
M tests/compiler/dart2js/inference/inference_test_helper.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 6 months ago (2017-06-16 10:51:42 UTC) #2
ahe
lgtm
3 years, 6 months ago (2017-06-16 10:55:27 UTC) #3
ahe
Thank you!
3 years, 6 months ago (2017-06-16 10:55:38 UTC) #4
Johnni Winther
3 years, 6 months ago (2017-06-16 11:01:06 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1b580129bfad286ae2b0cbc1286b8ffbd36a7266 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698