Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer.h

Issue 2939943004: Fix duplicate logging of ActiveBrowserChanged action on views. (Closed)
Patch Set: Fix ChromeVisibilityObserverBrowserTest on windows. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer.h
diff --git a/chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer.h b/chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer.h
index 3122503228513733ac01f1607dc47232b132e0ba..7740391d4d43da57a1ec31ae0f1b8b4d38c177ab 100644
--- a/chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer.h
+++ b/chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer.h
@@ -21,10 +21,6 @@ class ChromeVisibilityObserver : public chrome::BrowserListObserver {
// by tests.
virtual void SendVisibilityChangeEvent(bool active, base::TimeDelta time_ago);
- // chrome::BrowserListObserver:
- // In protected section for test.
- void OnBrowserRemoved(Browser* browser) override;
-
private:
// Cancels visibility change in case when the browser becomes visible after a
// short gap.
@@ -33,6 +29,7 @@ class ChromeVisibilityObserver : public chrome::BrowserListObserver {
// chrome::BrowserListObserver:
void OnBrowserSetLastActive(Browser* browser) override;
void OnBrowserNoLongerActive(Browser* browser) override;
+ void OnBrowserRemoved(Browser* browser) override;
// Sets |visibility_gap_timeout_| based on variation params.
void InitVisibilityGapTimeout();
« no previous file with comments | « no previous file | chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698