sync: Block reflections in more integration tests

sync: Block reflections in more integration tests

Enables reflection blocking for several groups of integration tests.
These tests have been ready for this change for a while, but we never
got around to setting the flag until now.

BUG=97780
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274433

[rlarocque, 2014-05-22 23:27:39]

These tests are no longer using AwaitQuiescence or any of the Await functions
derived from it.  It should be safe to disable self-notifications for them.

Patrick: Please review.
Nicolas: Please provide the official owners stamp of approval.

[pval...(no longer on Chromium), 2014-05-22 23:50:21]

lgtm

[rlarocque, 2014-05-23 00:22:37]

+Nicolas, since I forgot to add him in the original request.

[Nicolas Zea, 2014-05-23 20:21:59]

On 2014/05/23 00:22:37, rlarocque wrote:
> +Nicolas, since I forgot to add him in the original request.

"if it LGTM to pvalenzuela, it LGTMe"

[rlarocque, 2014-05-23 22:45:24]

On 2014/05/23 20:21:59, Nicolas Zea wrote:
> On 2014/05/23 00:22:37, rlarocque wrote:
> > +Nicolas, since I forgot to add him in the original request.
> 
> "if it LGTM to pvalenzuela, it LGTMe"

This CL is non-urgent and has the potential to flakify the integration tests, so
I'm going to resist temptation and not commit it on a Friday afternoon before a
long weekend.  I plan to commit it on Tuesday morning.

Thanks for the reviews.

[rlarocque, 2014-05-27 17:32:07]

The CQ bit was checked by rlarocque@chromium.org

[commit-bot: I haz the power, 2014-05-27 17:32:52]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rlarocque@chromium.org/293993019/1

[commit-bot: I haz the power, 2014-05-27 20:50:15]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[rlarocque, 2014-05-27 21:33:26]

The CQ bit was unchecked by rlarocque@chromium.org

[rlarocque, 2014-05-27 21:37:00]

On 2014/05/27 21:33:26, rlarocque wrote:
> The CQ bit was unchecked by mailto:rlarocque@chromium.org

I've unchecked the commit box.  Looks like there's an issue with
MultipleClientSessionsSyncTest.EncryptedAndChanged.  It's been known to be flaky
and disabled on several platforms since since 2011, so I'm not sure this change
is at fault, but I'll take some time to investigate just the same.

[rlarocque, 2014-06-02 18:22:48]

On 2014/05/27 21:37:00, rlarocque wrote:
> On 2014/05/27 21:33:26, rlarocque wrote:
> > The CQ bit was unchecked by mailto:rlarocque@chromium.org
> 
> I've unchecked the commit box.  Looks like there's an issue with
> MultipleClientSessionsSyncTest.EncryptedAndChanged.  It's been known to be
flaky
> and disabled on several platforms since since 2011, so I'm not sure this
change
> is at fault, but I'll take some time to investigate just the same.

It turns out the failure is legitimate, and the reason why it fails is obvious. 
The EncryptedAndChanged test still relies on an AwaitQuiescence() call for one
of its assertions.  It's no surprised that this sometimes doesn't work when
reflection blocking is disabled.

This CL was intended to enable reflection blocking for the tests that already
support it.  I would like to refactor that test, this CL is not the right place
to do so.  I've removed the reflection-blocking support from the
MultipleCLientSessionsSyncTest harness.  We can refactor the test and try again
to enable reflection blocking in another CL.

I'll upload a new patch and send it at the CQ soon.

[rlarocque, 2014-06-02 21:45:18]

The CQ bit was checked by rlarocque@chromium.org

[commit-bot: I haz the power, 2014-06-02 21:47:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rlarocque@chromium.org/293993019/20001

[commit-bot: I haz the power, 2014-06-03 01:43:41]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-06-03 08:45:31]

Change committed as 274433