Add a breakpad / content_shell integration test

Add a breakpad / content_shell integration test

The test is supposed to ensure that the breakpad component is correctly
hooked up to content_shell, and that the surrounding tools can actually
convert a crash into a symbolized stack dump.

This version is currently Linux-only, other platforms will be added.

The test is based on
http://www.chromium.org/developers/testing/webkit-layout-tests/using-breakpad-with-content-shell

This would have caught e.g. a call to base::GetLinuxDistro() being added
on the UI thread, or dump_syms not supporting debug fission yet.

The test needs to be executed like this:

 $ content/shell/tools/breakpad_integration_test.py \
      --build-dir=out/Debug --binary=out/Debug/content_shell
 # Generate symbols.
 # Run content_shell and make it crash.
 # Retrieve crash dump.
 # Symbolize crash dump.
 PASS: Breakpad integration test ran successfully.

BUG=372928
R=thestig@chromium.org, rsesek@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272444

[Lei Zhang, 2014-05-23 03:13:53]

https://codereview.chromium.org/293993017/diff/1/content/shell/tools/breakpad...
File content/shell/tools/breakpad_integration_test.py (right):

https://codereview.chromium.org/293993017/diff/1/content/shell/tools/breakpad...
content/shell/tools/breakpad_integration_test.py:61: 'components', 'breakpad',
'tools', 'generate_breakpad_symbols.py')
this should be relative to breakpad_integration_test.py and out the build_dir.

https://codereview.chromium.org/293993017/diff/1/content/shell/tools/breakpad...
content/shell/tools/breakpad_integration_test.py:91: failure = 'Could not find a
single crash dump.'
This is slightly confusing, maybe change it to: 'Expected 1 crash dump, found
%d.' % len(dump_files)

And only raise() with this message if len(dmp_files) != 1 ?

https://codereview.chromium.org/293993017/diff/1/content/shell/tools/breakpad...
content/shell/tools/breakpad_integration_test.py:99: 'components', 'breakpad',
'tools', 'dmp2minidump.py')
same comment as line 61

https://codereview.chromium.org/293993017/diff/1/content/shell/tools/breakpad...
content/shell/tools/breakpad_integration_test.py:140: try:
put the above rmtree() attempt inside finally: and remove this one?

[Lei Zhang, 2014-05-23 05:22:50]

https://codereview.chromium.org/293993017/diff/1/content/shell/tools/breakpad...
File content/shell/tools/breakpad_integration_test.py (right):

https://codereview.chromium.org/293993017/diff/1/content/shell/tools/breakpad...
content/shell/tools/breakpad_integration_test.py:78: '--enable-crash-reporter',
Oh, please use --enable-crash-reporter-for-testing and not
--enable-crash-reporter. You'll need to update the documentation and I'll help
correct this.

--enable-crash-reporter is suppose to be an internal communication channel
between the browser and sandboxed renderers, not an external switch for users to
pass in.

[Lei Zhang, 2014-05-23 07:19:10]

On 2014/05/23 05:22:50, Lei Zhang wrote:
>
https://codereview.chromium.org/293993017/diff/1/content/shell/tools/breakpad...
> File content/shell/tools/breakpad_integration_test.py (right):
> 
>
https://codereview.chromium.org/293993017/diff/1/content/shell/tools/breakpad...
> content/shell/tools/breakpad_integration_test.py:78:
'--enable-crash-reporter',
> Oh, please use --enable-crash-reporter-for-testing and not
> --enable-crash-reporter. You'll need to update the documentation and I'll help
> correct this.
> 
> --enable-crash-reporter is suppose to be an internal communication channel
> between the browser and sandboxed renderers, not an external switch for users
to
> pass in.

Actually, nevermind. I forgot about Windows, where
--enable-crash-reporter-for-testing doesn't exist and --enable-crash-reporter
does what it says it does.

[jochen (gone - plz use gerrit), 2014-05-23 07:22:21]

https://codereview.chromium.org/293993017/diff/1/content/shell/tools/breakpad...
File content/shell/tools/breakpad_integration_test.py (right):

https://codereview.chromium.org/293993017/diff/1/content/shell/tools/breakpad...
content/shell/tools/breakpad_integration_test.py:61: 'components', 'breakpad',
'tools', 'generate_breakpad_symbols.py')
On 2014/05/23 03:13:53, Lei Zhang wrote:
> this should be relative to breakpad_integration_test.py and out the build_dir.

Done.

https://codereview.chromium.org/293993017/diff/1/content/shell/tools/breakpad...
content/shell/tools/breakpad_integration_test.py:78: '--enable-crash-reporter',
On 2014/05/23 05:22:51, Lei Zhang wrote:
> Oh, please use --enable-crash-reporter-for-testing and not
> --enable-crash-reporter. You'll need to update the documentation and I'll help
> correct this.
> 
> --enable-crash-reporter is suppose to be an internal communication channel
> between the browser and sandboxed renderers, not an external switch for users
to
> pass in.

--enable-crash-reporter-for-testing is a linux only option. I hooked up the
content shell code to use --enable-crash-reporter

https://codereview.chromium.org/293993017/diff/1/content/shell/tools/breakpad...
content/shell/tools/breakpad_integration_test.py:91: failure = 'Could not find a
single crash dump.'
On 2014/05/23 03:13:53, Lei Zhang wrote:
> This is slightly confusing, maybe change it to: 'Expected 1 crash dump, found
> %d.' % len(dump_files)
> 
> And only raise() with this message if len(dmp_files) != 1 ?

Done.

https://codereview.chromium.org/293993017/diff/1/content/shell/tools/breakpad...
content/shell/tools/breakpad_integration_test.py:99: 'components', 'breakpad',
'tools', 'dmp2minidump.py')
On 2014/05/23 03:13:53, Lei Zhang wrote:
> same comment as line 61

Done.

https://codereview.chromium.org/293993017/diff/1/content/shell/tools/breakpad...
content/shell/tools/breakpad_integration_test.py:140: try:
On 2014/05/23 03:13:53, Lei Zhang wrote:
> put the above rmtree() attempt inside finally: and remove this one?

Done.

[Lei Zhang, 2014-05-23 07:32:14]

lgtm

https://codereview.chromium.org/293993017/diff/10001/content/shell/tools/brea...
File content/shell/tools/breakpad_integration_test.py (right):

https://codereview.chromium.org/293993017/diff/10001/content/shell/tools/brea...
content/shell/tools/breakpad_integration_test.py:99: 'components', 'breakpad',
'tools', 'dmp2minidump.py')
maybe figure out the path to component/breakpad/tools above and use it again
here.

https://codereview.chromium.org/293993017/diff/10001/content/shell/tools/brea...
content/shell/tools/breakpad_integration_test.py:116: found_symbol =
stack.find('CrashIntentionally') != -1
Since we don't care about the position, how about:

found_symbol = 'CrashIntentionally' in stack

https://codereview.chromium.org/293993017/diff/10001/content/shell/tools/brea...
content/shell/tools/breakpad_integration_test.py:143: print 'Failed to delete
temp directory.'
print the name of the temp dir.

[jochen (gone - plz use gerrit), 2014-05-23 08:02:37]

Committed patchset #3 manually as r272444 (presubmit successful).