Issue 293993006: Revert of Remove SandboxBPF's dependency on CompatibilityPolicy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 293993006: Revert of Remove SandboxBPF's dependency on CompatibilityPolicy (Closed)

Created:
6 years, 7 months ago by Ilya Sherman

Modified:
6 years, 7 months ago

Reviewers:
jln (very slow on Chromium), mdempsky

CC:
chromium-reviews, agl, jln+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Revert of Remove SandboxBPF's dependency on CompatibilityPolicy (https://codereview.chromium.org/290223002/) Reason for revert: Broke VerboseAPITesting in sandbox_linux_unittests on Linux: http://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20Tests%20%28dbg%29%282%29%2832%29&number=13046 Original issue's description: > Remove SandboxBPF's dependency on CompatibilityPolicy > > SandboxBPF users are now required to always provide a SandboxBPFPolicy > instead of a SyscallEvaluator. CompatibilityPolicy can't be removed > just yet though because it's still used by the deprecated BPF_TEST > macros. > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271607 TBR=jln@chromium.org,mdempsky@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271621

Created: 6 years, 7 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+111 lines, -127 lines)			Patch
M	sandbox/linux/seccomp-bpf/demo.cc	View	3 chunks	+2 lines, -15 lines	0 comments	Download
M	sandbox/linux/seccomp-bpf/sandbox_bpf.h	View	3 chunks	+24 lines, -1 line	0 comments	Download
M	sandbox/linux/seccomp-bpf/sandbox_bpf.cc	View	7 chunks	+33 lines, -39 lines	0 comments	Download
M	sandbox/linux/seccomp-bpf/sandbox_bpf_unittest.cc	View	4 chunks	+52 lines, -72 lines	0 comments	Download

Total messages: 4 (0 generated)

Ilya Sherman

Created Revert of Remove SandboxBPF's dependency on CompatibilityPolicy

6 years, 7 months ago (2014-05-20 11:15:42 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/293993006/1

6 years, 7 months ago (2014-05-20 11:15:57 UTC) #2

Message was sent while issue was closed.

lgtm