Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: components/autofill/content/renderer/page_click_tracker.cc

Issue 293993004: Replace WebElement::hasTagName with hasHTMLTagName in autofill (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/page_click_tracker.cc
diff --git a/components/autofill/content/renderer/page_click_tracker.cc b/components/autofill/content/renderer/page_click_tracker.cc
index 112d8e86633de60d91579ec4ddd3ee43be741fc5..98c9c98e846d5aeeb67b33499d7aeb0a3813234c 100644
--- a/components/autofill/content/renderer/page_click_tracker.cc
+++ b/components/autofill/content/renderer/page_click_tracker.cc
@@ -37,7 +37,7 @@ const WebInputElement GetTextWebInputElement(const WebNode& node) {
if (!node.isElementNode())
return WebInputElement();
const WebElement element = node.toConst<WebElement>();
- if (!element.hasTagName("input"))
+ if (!element.hasHTMLTagName("input"))
return WebInputElement();
const WebInputElement* input = blink::toWebInputElement(&element);
if (!autofill::IsTextInput(input))
@@ -48,11 +48,11 @@ const WebInputElement GetTextWebInputElement(const WebNode& node) {
// Casts |node| to a WebTextAreaElement.
// Returns an empty (isNull()) WebTextAreaElement if |node| is not a
// textarea field.
-const WebTextAreaElement GetTextWebTextAreaElement(const WebNode& node) {
+const WebTextAreaElement GetWebTextAreaElement(const WebNode& node) {
if (!node.isElementNode())
return WebTextAreaElement();
const WebElement element = node.toConst<WebElement>();
- if (!element.hasTagName("textarea"))
+ if (!element.hasHTMLTagName("textarea"))
return WebTextAreaElement();
return element.toConst<WebTextAreaElement>();
}
@@ -65,7 +65,7 @@ bool DidSelectedTextFieldLoseFocus(const WebNode& newly_clicked_node) {
if (focused_element.isNull() ||
(GetTextWebInputElement(focused_element).isNull() &&
- GetTextWebTextAreaElement(focused_element).isNull()))
+ GetWebTextAreaElement(focused_element).isNull()))
return false;
return focused_element != newly_clicked_node;
@@ -101,7 +101,7 @@ void PageClickTracker::DidHandleMouseEvent(const WebMouseEvent& event) {
const WebInputElement input_element =
GetTextWebInputElement(last_node_clicked_);
const WebTextAreaElement textarea_element =
- GetTextWebTextAreaElement(last_node_clicked_);
+ GetWebTextAreaElement(last_node_clicked_);
if (input_element.isNull() && textarea_element.isNull())
return;
@@ -152,7 +152,7 @@ void PageClickTracker::handleEvent(const WebDOMEvent& event) {
// We are only interested in text field clicks.
if (GetTextWebInputElement(node).isNull() &&
- GetTextWebTextAreaElement(node).isNull())
+ GetWebTextAreaElement(node).isNull())
return;
last_node_clicked_ = node;

Powered by Google App Engine
This is Rietveld 408576698