Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 293993004: Replace WebElement::hasTagName with hasHTMLTagName in autofill (Closed)

Created:
6 years, 7 months ago by keishi
Modified:
6 years, 7 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, benquan, jam, browser-components-watch_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, mkwst+watchlist_chromium.org, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

Replace WebElement::hasTagName with hasHTMLTagName in autofill BUG=374725, 358235 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272000

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : Reverted GetTextWebInputElement #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M components/autofill/content/renderer/form_autofill_util.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/autofill/content/renderer/page_click_tracker.cc View 1 2 3 5 chunks +6 lines, -6 lines 0 comments Download
M components/autofill/content/renderer/password_autofill_agent.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
keishi
CL replacing https://codereview.chromium.org/295603002/ Replaces all usage of hasTagName in autofill module with hasHTMLTagName
6 years, 7 months ago (2014-05-20 14:57:21 UTC) #1
Ilya Sherman
LGTM, thanks! https://codereview.chromium.org/293993004/diff/20001/components/autofill/content/renderer/page_click_tracker.cc File components/autofill/content/renderer/page_click_tracker.cc (right): https://codereview.chromium.org/293993004/diff/20001/components/autofill/content/renderer/page_click_tracker.cc#newcode36 components/autofill/content/renderer/page_click_tracker.cc:36: const WebInputElement GetWebInputElement(const WebNode& node) { nit: ...
6 years, 7 months ago (2014-05-20 14:59:11 UTC) #2
keishi
The CQ bit was checked by keishi@chromium.org
6 years, 7 months ago (2014-05-21 01:55:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/293993004/40001
6 years, 7 months ago (2014-05-21 01:56:09 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-21 07:58:30 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-21 08:24:31 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/18456)
6 years, 7 months ago (2014-05-21 08:24:31 UTC) #7
keishi
The CQ bit was checked by keishi@chromium.org
6 years, 7 months ago (2014-05-21 09:39:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/293993004/60001
6 years, 7 months ago (2014-05-21 09:40:20 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-21 22:50:37 UTC) #10
Message was sent while issue was closed.
Change committed as 272000

Powered by Google App Engine
This is Rietveld 408576698