MD Bookmarks: Fix issue where keyboard shortcuts could fire incorrectly

chrome/test/data/webui/md_bookmarks/command_manager_test.js

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 suite('<bookmarks-command-manager>', function() {
   var commandManager;
   var store;
   var lastCommand;
   var lastCommandIds;
 
@@ skipping 106 matching lines @@
     store.notifyObservers();
 
     MockInteractions.pressAndReleaseKeyOn(document.body, keyCode, '', key);
     commandManager.assertLastCommand('edit', ['11']);
   });
 
   test('undo and redo commands trigger', function() {
     var undoModifier = cr.isMac ? 'meta' : 'ctrl';
     var undoKey = 'z';
     var redoModifier = cr.isMac ? ['meta', 'shift'] : 'ctrl'
-    var redoKey = cr.isMac ? 'z' : 'y';
+    var redoKey = cr.isMac ? 'Z' : 'y';
 
     MockInteractions.pressAndReleaseKeyOn(
         document.body, '', undoModifier, undoKey);
     commandManager.assertLastCommand('undo');
 
     MockInteractions.pressAndReleaseKeyOn(
         document.body, '', redoModifier, redoKey);
     commandManager.assertLastCommand('redo');
   });
 
@@ skipping 26 matching lines @@
     chrome.windows.create = function(createConfig) {
       lastCreate = createConfig;
     };
 
     MockInteractions.pressAndReleaseKeyOn(document.body, 13, 'shift', 'Enter');
     commandManager.assertLastCommand(Command.OPEN_NEW_WINDOW, ['12', '13']);
     assertDeepEquals(['http://121/', 'http://13/'], lastCreate.url);
     assertFalse(lastCreate.incognito);
   });
 
+  test('shift-enter does not trigger enter commands', function() {
+    // Enter by itself performs an edit (Mac) or open (non-Mac). Ensure that
+    // shift-enter doesn't trigger those commands.
+    store.data.selection.items = new Set(['13']);
+    store.notifyObservers();
+
+    MockInteractions.pressAndReleaseKeyOn(document.body, 13, 'shift', 'Enter');
+    commandManager.assertLastCommand(Command.OPEN_NEW_WINDOW);
+  });
+
   test('cannot execute "Open in New Tab" on folders with no items', function() {
     var items = new Set(['2']);
     assertFalse(commandManager.canExecute(Command.OPEN_NEW_TAB, items));
 
     store.data.selection.items = items;
 
     commandManager.openCommandMenuAtPosition(0, 0);
     var commandItem = {};
     commandManager.root.querySelectorAll('.dropdown-item').forEach(element => {
       commandItem[element.getAttribute('command')] = element;
@@ skipping 112 matching lines @@
     assertOpenedTabs(['http://111/', 'http://12/']);
   });
 
   test('control-double click opens full selection', function() {
     customClick(items[0]);
     simulateDoubleClick(items[2], {ctrlKey: true});
 
     assertOpenedTabs(['http://111/', 'http://13/']);
   });
 });