mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl - Issue 293983026: Mojo cpp bindings: remove redundant validation in Decode*().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

Issue 293983026: Mojo cpp bindings: remove redundant validation in Decode*(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/cpp/bindings/lib/bindings_serialization.cc ('k') | mojo/public/tools/bindings/generators/cpp_templates/params_definition.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

index fe0a7101bc3f817efe489e147de5eb0ee36caae1..5df835c24a809bf9429a192436946e5661ff6e2e 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

@@ -100,8 +100,7 @@ bool {{class_name}}_{{method.name}}_ForwardToCallback::Accept(

reinterpret_cast<internal::{{class_name}}_{{method.name}}_ResponseParams_Data*>(

message->mutable_payload());

- if (!params->DecodePointersAndHandles(message))

- return false;

+ params->DecodePointersAndHandles(message->mutable_handles());

callback_.Run({{pass_params(method.response_parameters)}});

return true;

@@ -205,8 +204,7 @@ bool {{class_name}}Stub::Accept(mojo::Message* message) {

reinterpret_cast<internal::{{class_name}}_{{method.name}}_Params_Data*>(

message->mutable_payload());

- if (!params->DecodePointersAndHandles(message))

- return false;

+ params->DecodePointersAndHandles(message->mutable_handles());

sink_->{{method.name}}({{pass_params(method.parameters)}});

return true;

@@ -231,8 +229,7 @@ bool {{class_name}}Stub::AcceptWithResponder(

reinterpret_cast<internal::{{class_name}}_{{method.name}}_Params_Data*>(

message->mutable_payload());

- if (!params->DecodePointersAndHandles(message))

- return false;

+ params->DecodePointersAndHandles(message->mutable_handles());

{{interface_macros.declare_callback(method)}}::Runnable* runnable =

new {{class_name}}_{{method.name}}_ProxyToResponder(

message->request_id(), responder);