Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1079)

Unified Diff: Source/core/svg/SVGElement.cpp

Issue 293983020: SVG: Remove JSC specific workaround in SVGElement::removeEventListener (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebased Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGElement.cpp
diff --git a/Source/core/svg/SVGElement.cpp b/Source/core/svg/SVGElement.cpp
index 7b84ce2671c2a15a0a07e0219a01a881266e0b29..a567999d9cafb910faacd4b635e881214b46b36a 100644
--- a/Source/core/svg/SVGElement.cpp
+++ b/Source/core/svg/SVGElement.cpp
@@ -843,22 +843,7 @@ bool SVGElement::removeEventListener(const AtomicString& eventType, EventListene
SVGElement* shadowTreeElement = *it;
ASSERT(shadowTreeElement);
- if (shadowTreeElement->Node::removeEventListener(eventType, listener, useCapture))
- continue;
-
- // This case can only be hit for event listeners created from markup
- ASSERT(listener->wasCreatedFromMarkup());
-
- // If the event listener 'listener' has been created from markup and has been fired before
- // then JSLazyEventListener::parseCode() has been called and m_jsFunction of that listener
- // has been created (read: it's not 0 anymore). During shadow tree creation, the event
- // listener DOM attribute has been cloned, and another event listener has been setup in
- // the shadow tree. If that event listener has not been used yet, m_jsFunction is still 0,
- // and tryRemoveEventListener() above will fail. Work around that very seldom problem.
- EventTargetData* data = shadowTreeElement->eventTargetData();
- ASSERT(data);
-
- data->eventListenerMap.removeFirstEventListenerCreatedFromMarkup(eventType);
+ shadowTreeElement->Node::removeEventListener(eventType, listener, useCapture);
}
return true;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698