Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 293983020: SVG: Remove JSC specific workaround in SVGElement::removeEventListener (Closed)

Created:
6 years, 7 months ago by kouhei (in TOK)
Modified:
6 years, 6 months ago
Reviewers:
pdr., esprehn
CC:
blink-reviews, krit, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, kouhei+svg_chromium.org, rwlbuis
Visibility:
Public.

Description

SVG: Remove JSC specific workaround in SVGElement::removeEventListener The workaround seems specific to JSC, and thus not needed in Blink. BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175778

Patch Set 1 #

Patch Set 2 : ASSERT_UNUSED #

Total comments: 1

Patch Set 3 : remove assert #

Patch Set 4 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -16 lines) Patch
M Source/core/svg/SVGElement.cpp View 1 2 3 1 chunk +1 line, -16 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
kouhei (in TOK)
6 years, 7 months ago (2014-05-23 07:33:11 UTC) #1
kouhei (in TOK)
https://codereview.chromium.org/293983020/diff/20001/Source/core/svg/SVGElement.cpp File Source/core/svg/SVGElement.cpp (right): https://codereview.chromium.org/293983020/diff/20001/Source/core/svg/SVGElement.cpp#newcode851 Source/core/svg/SVGElement.cpp:851: ASSERT_UNUSED(removeSuccess, removeSuccess); The failing tests manually remove certain eventhandlers ...
6 years, 7 months ago (2014-05-23 09:35:30 UTC) #2
pdr.
On 2014/05/23 09:35:30, kouhei wrote: > https://codereview.chromium.org/293983020/diff/20001/Source/core/svg/SVGElement.cpp > File Source/core/svg/SVGElement.cpp (right): > > https://codereview.chromium.org/293983020/diff/20001/Source/core/svg/SVGElement.cpp#newcode851 > ...
6 years, 7 months ago (2014-05-23 23:01:50 UTC) #3
esprehn
This seems to cause real failures: svg/custom/use-instanceRoot-as-event-target.xhtml svg/custom/use-instanceRoot-event-listeners.xhtml
6 years, 6 months ago (2014-06-06 01:25:22 UTC) #4
kouhei (in TOK)
On 2014/06/06 01:25:22, esprehn wrote: > This seems to cause real failures: > > svg/custom/use-instanceRoot-as-event-target.xhtml ...
6 years, 6 months ago (2014-06-06 07:01:15 UTC) #5
kouhei (in TOK)
On 2014/06/06 07:01:15, kouhei wrote: > On 2014/06/06 01:25:22, esprehn wrote: > > This seems ...
6 years, 6 months ago (2014-06-09 05:57:41 UTC) #6
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 6 months ago (2014-06-09 05:57:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/293983020/60001
6 years, 6 months ago (2014-06-09 05:58:17 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-09 07:05:07 UTC) #9
Message was sent while issue was closed. 
Change committed as 175778

Powered by Google App Engine
This is Rietveld 408576698