Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 293983017: Always write .landmines (Closed)

Created:
6 years, 7 months ago by scottmg
Modified:
6 years, 7 months ago
CC:
chromium-reviews, ghost stip (do not use), agable, hinoka
Visibility:
Public.

Description

Always write .landmines Otherwise, if .landmines exists, and isn't clobbered by the clobber in compile.py, every build will cause a clobber until .landmines is removed. Trying to fix http://crbug.com/375459 brought this up. In that case compile.py wasn't removing .landmines, which is necessary in the case of a landmines change on two subsequent builds. If .landmines isn't maintained, then there's nothing to diff against on the second build and so a clobber won't be correctly triggered. R=iannucci@chromium.org,kbr@chromium.org BUG=376359 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272341

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M build/landmines.py View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
scottmg
6 years, 7 months ago (2014-05-22 17:58:08 UTC) #1
Ken Russell (switch to Gerrit)
LGTM. I think this, combined with the change to compile.py to skip deleting .landmines during ...
6 years, 7 months ago (2014-05-22 18:19:17 UTC) #2
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 7 months ago (2014-05-22 18:21:59 UTC) #3
scottmg
On 2014/05/22 18:19:17, Ken Russell wrote: > LGTM. I think this, combined with the change ...
6 years, 7 months ago (2014-05-22 18:23:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/293983017/1
6 years, 7 months ago (2014-05-22 18:24:41 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-22 22:12:53 UTC) #6
Message was sent while issue was closed.
Change committed as 272341

Powered by Google App Engine
This is Rietveld 408576698