Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 293983010: win: Enable PDF for metafile as default (Closed)

Created:
6 years, 7 months ago by scottmg
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

win: Enable PDF for metafile as default Main code landed at r271772. This can be on by default now that internal_pdf is gone. If this seems stable after some releases I'll remove the gyp flag and related code. R=vitalybuka@chromium.org BUG=170859 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272250

Patch Set 1 #

Patch Set 2 : only use on windows #

Patch Set 3 : disable pdf image tests similar to linux #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M build/common.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/printing/print_web_view_helper_browsertest.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
scottmg
6 years, 7 months ago (2014-05-21 18:55:58 UTC) #1
Vitaly Buka (NO REVIEWS)
lgtm
6 years, 7 months ago (2014-05-21 19:03:38 UTC) #2
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 7 months ago (2014-05-21 20:08:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/293983010/20001
6 years, 7 months ago (2014-05-21 20:11:50 UTC) #4
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 7 months ago (2014-05-22 00:25:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/293983010/40001
6 years, 7 months ago (2014-05-22 00:30:03 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 10:11:28 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-22 10:14:27 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/9713)
6 years, 7 months ago (2014-05-22 10:14:27 UTC) #9
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 7 months ago (2014-05-22 18:28:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/293983010/40001
6 years, 7 months ago (2014-05-22 18:29:45 UTC) #11
commit-bot: I haz the power
6 years, 7 months ago (2014-05-22 18:39:02 UTC) #12
Message was sent while issue was closed.
Change committed as 272250

Powered by Google App Engine
This is Rietveld 408576698