Issue 293983007: Add Makefiles to support building along with LLVM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 293983007: Add Makefiles to support building along with LLVM (Closed)

Created:
6 years, 7 months ago by Derek Schuff

Modified:
6 years, 7 months ago

Reviewers:
jvoung (off chromium), Jim Stichnoth

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Visibility:
Public.

More Reviews

Description

Add Makefiles to support building along with LLVM This change now supports building subzero as part of the LLVM build (instead of in a separate build step). It is modeled on clang's Makefiles. The existing Makefile has been renamed and can still be used manually, e.g. Make -f Makefile.standalone It does not yet support running tests, just building. R=stichnot@chromium.org, jvoung@chromium.org BUG= Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=bc64313

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -74 lines)			Patch
M	Makefile	View	1	1 chunk	+10 lines, -75 lines	0 comments	Download
A +	Makefile.standalone	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A	src/Makefile	View		1 chunk	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Derek Schuff

This depends on https://codereview.chromium.org/299753004 Is there a good BUG= for this?

6 years, 7 months ago (2014-05-21 00:55:42 UTC) #1

Jim Stichnoth

LGTM modulo the git nit. https://codereview.chromium.org/293983007/diff/1/src/Makefile File src/Makefile (right): https://codereview.chromium.org/293983007/diff/1/src/Makefile#newcode13 src/Makefile:13: Git complained about extraneous ...

6 years, 7 months ago (2014-05-22 16:56:48 UTC) #2

Derek Schuff

Committed patchset #2 manually as rbc64313 (presubmit successful).

6 years, 7 months ago (2014-05-22 23:39:30 UTC) #3

Derek Schuff

6 years, 7 months ago (2014-05-22 23:42:38 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/293983007/diff/1/src/Makefile
File src/Makefile (right):

https://codereview.chromium.org/293983007/diff/1/src/Makefile#newcode13
src/Makefile:13: 
On 2014/05/22 16:56:48, stichnot wrote:
> Git complained about extraneous whitespace (blank line).  :)

Done.

Expand Messages | Collapse Messages