Use API signatures for library cycle signatures when possible.

Use API signatures for library cycle signatures when possible.

If there are mixin applications, we still have to use full content hashes.

R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/0912f3c6405e56c7ea9d52dfc49a3c53756aff3f

[Paul Berry, 2017-06-13 18:06:49]

https://codereview.chromium.org/2939743002/diff/1/pkg/front_end/lib/src/incre...
File pkg/front_end/lib/src/incremental_kernel_generator_impl.dart (right):

https://codereview.chromium.org/2939743002/diff/1/pkg/front_end/lib/src/incre...
pkg/front_end/lib/src/incremental_kernel_generator_impl.dart:160:
cycle.directUsers.forEach(gatherVmRequiredLibraryCycles);
I think the VM needs the transitive closure of users of a library cycle, not
just direct users.  This is because an inlined function might contain a call to
another function which is also inlined.

[Paul Berry, 2017-06-13 18:09:50]

lgtm

https://codereview.chromium.org/2939743002/diff/1/pkg/front_end/lib/src/incre...
File pkg/front_end/lib/src/incremental_kernel_generator_impl.dart (right):

https://codereview.chromium.org/2939743002/diff/1/pkg/front_end/lib/src/incre...
pkg/front_end/lib/src/incremental_kernel_generator_impl.dart:160:
cycle.directUsers.forEach(gatherVmRequiredLibraryCycles);
On 2017/06/13 18:06:49, Paul Berry wrote:
> I think the VM needs the transitive closure of users of a library cycle, not
> just direct users.  This is because an inlined function might contain a call
to
> another function which is also inlined.

Never mind.  As you pointed out in person, this is already handled by the
recursive call of gatherVmRequiredLibraryCycles to itself.

[scheglov, 2017-06-13 18:39:33]

Description was changed from

==========
Use API signatures for library cycle signatures when possible.

If there are mixin applications, we still have to use full content hashes.

R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=
==========

to

==========
Use API signatures for library cycle signatures when possible.

If there are mixin applications, we still have to use full content hashes.

R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/0912f3c6405e56c7ea9d52dfc49a3c53756aff3f
==========

[scheglov, 2017-06-13 18:39:35]

Committed patchset #1 (id:1) manually as
0912f3c6405e56c7ea9d52dfc49a3c53756aff3f (presubmit successful).