Issue 293963008: Make compilation VM tags more fine grained

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 293963008: Make compilation VM tags more fine grained (Closed)

Created:
6 years, 7 months ago by Cutch

Modified:
6 years, 6 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make compilation VM tags more fine grained BUG=

Patch Set 1 #

Total comments: 1

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -6 lines)			Patch
M	runtime/vm/compiler.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	runtime/vm/object.cc	View	1 chunk	+0 lines, -1 line	1 comment	Download
M	runtime/vm/parser.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/scanner.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/tags.h	View	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM -ip https://codereview.chromium.org/293963008/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (left): https://codereview.chromium.org/293963008/diff/1/runtime/vm/object.cc#oldcode7857 runtime/vm/object.cc:7857: VMTagScope tagScope(isolate, VMTag::kCompileTagId); Why not set the ...

6 years, 7 months ago (2014-05-21 18:01:31 UTC) #2

Ivan Posva

6 years, 6 months ago (2014-06-09 20:50:32 UTC) #4

On 2014/06/05 23:45:47, Ivan Posva wrote:
> Is this still an active review?
> 
> -Ivan

Closing. -ip

Expand Messages | Collapse Messages