Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 293963007: Make content/common compile on Linux GN build. (Closed)

Created:
6 years, 7 months ago by brettw
Modified:
6 years, 7 months ago
Reviewers:
scottmg
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Make content/common compile on Linux GN build. BUG= R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271982

Patch Set 1 #

Total comments: 6

Patch Set 2 : review comments #

Patch Set 3 : #

Patch Set 4 : merge #

Patch Set 5 : add stub header dirs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+296 lines, -7 lines) Patch
M BUILD.gn View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
A content/BUILD.gn View 1 2 3 4 1 chunk +53 lines, -0 lines 0 comments Download
M content/common/BUILD.gn View 1 2 3 4 3 chunks +232 lines, -2 lines 0 comments Download
M content/content_common.gypi View 1 1 chunk +0 lines, -5 lines 0 comments Download
M content/public/common/BUILD.gn View 1 2 3 4 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
brettw
This is a first step that compiles. The files compile but obviously won't link into ...
6 years, 7 months ago (2014-05-20 23:56:00 UTC) #1
scottmg
wow, that file. https://codereview.chromium.org/293963007/diff/1/content/common/BUILD.gn File content/common/BUILD.gn (right): https://codereview.chromium.org/293963007/diff/1/content/common/BUILD.gn#newcode94 content/common/BUILD.gn:94: sources -= [ "cursors/webcursor_mac.mm" ] this ...
6 years, 7 months ago (2014-05-21 00:30:33 UTC) #2
brettw
https://codereview.chromium.org/293963007/diff/1/content/common/BUILD.gn File content/common/BUILD.gn (right): https://codereview.chromium.org/293963007/diff/1/content/common/BUILD.gn#newcode94 content/common/BUILD.gn:94: sources -= [ "cursors/webcursor_mac.mm" ] The GYP code for ...
6 years, 7 months ago (2014-05-21 01:35:18 UTC) #3
scottmg
lgtmish https://codereview.chromium.org/293963007/diff/1/content/common/BUILD.gn File content/common/BUILD.gn (right): https://codereview.chromium.org/293963007/diff/1/content/common/BUILD.gn#newcode139 content/common/BUILD.gn:139: "font_list_pango.cc", On 2014/05/21 01:35:18, brettw wrote: > _pango ...
6 years, 7 months ago (2014-05-21 02:42:33 UTC) #4
brettw
https://codereview.chromium.org/293963007/diff/1/content/common/BUILD.gn File content/common/BUILD.gn (right): https://codereview.chromium.org/293963007/diff/1/content/common/BUILD.gn#newcode139 content/common/BUILD.gn:139: "font_list_pango.cc", I see, I think you're right. I'll fix ...
6 years, 7 months ago (2014-05-21 17:09:09 UTC) #5
brettw
6 years, 7 months ago (2014-05-21 22:01:58 UTC) #6
Message was sent while issue was closed. 
Committed patchset #5 manually as r271982 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698