runtime/vm/parser.h - Issue 2939553005: Updated parser to produce error when trying to reinitialize final variables in class constructors. …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/parser.h

Issue 2939553005: Updated parser to produce error when trying to reinitialize final variables in class constructors. … (Closed)

Patch Set: Addressed asiva's comments Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/parser.h

diff --git a/runtime/vm/parser.h b/runtime/vm/parser.h

index 9dd7e0f260c575af73ce1a4c859a4e2c2c292e7a..55612fd1b8dccdfc19aa6e16ab57cc4b298ba6e2 100644

--- a/runtime/vm/parser.h

+++ b/runtime/vm/parser.h

@@ -563,6 +563,7 @@ class Parser : public ValueObject {

void CheckMemberNameConflict(ClassDesc* members, MemberDesc* member);

void ParseClassMemberDefinition(ClassDesc* members,

TokenPosition metadata_pos);

+ void CheckFinalInitializationConflicts(ClassDesc* class_desc);

void ParseParameterType(ParamList* params);

void ParseFormalParameter(bool allow_explicit_default_value,

bool evaluate_metadata,

« no previous file with comments | « no previous file | runtime/vm/parser.cc » ('j') | runtime/vm/parser.cc » ('J')