Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(408)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: tests/language/final_attempt_reinitialization_test.dart
Issue
2939553005
:
Updated parser to produce error when trying to reinitialize final variables in class constructors. … (Closed)
Patch Set: Addressed final comment
Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
runtime/vm/parser.h
runtime/vm/parser.cc
tests/language/final_attempt_reinitialization_test.dart
tests/language/language_analyzer2.status
tests/language/language_dart2js.status
tests/language/language_kernel.status
View unified diff
|
Download patch
« no previous file with comments
|
« runtime/vm/parser.cc
('k') |
tests/language/language_analyzer2.status »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
// Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
2
// for details. All rights reserved. Use of this source code is governed by a
3
// BSD-style license that can be found in the LICENSE file.
4
5
class Foo {
6
Foo(this.x);
7
final int x = 42;
8
}
9
10
class CoffeeShop {
11
final String name = "Coffee Lab";
12
CoffeeShop.name(String name) : this.name = name;
13
}
14
15
void main() {
16
Foo f = new Foo(10); //# 01: compile-time error
17
CoffeeShop presidentialCoffee = //# 02: compile-time error
18
new CoffeeShop.name("Covfefe Lab"); //# 02: compile-time error
19
}
OLD
NEW
« no previous file with comments
|
« runtime/vm/parser.cc
('k') |
tests/language/language_analyzer2.status »
('j') |
no next file with comments »
Issue 2939553005: Updated parser to produce error when trying to reinitialize final variables in class constructors. … (Closed)
Created 3 years, 6 months ago by bkonyi
Modified 3 years, 6 months ago
Reviewers: zra, siva
Base URL:
Comments: 28
This is Rietveld
408576698