Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Side by Side Diff: runtime/vm/parser.h

Issue 2939553005: Updated parser to produce error when trying to reinitialize final variables in class constructors. … (Closed)
Patch Set: Addressed final comment Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | runtime/vm/parser.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef RUNTIME_VM_PARSER_H_ 5 #ifndef RUNTIME_VM_PARSER_H_
6 #define RUNTIME_VM_PARSER_H_ 6 #define RUNTIME_VM_PARSER_H_
7 7
8 #include "include/dart_api.h" 8 #include "include/dart_api.h"
9 9
10 #include "platform/assert.h" 10 #include "platform/assert.h"
(...skipping 545 matching lines...) Expand 10 before | Expand all | Expand 10 after
556 bool allow_void, 556 bool allow_void,
557 ClassFinalizer::FinalizationKind finalization); 557 ClassFinalizer::FinalizationKind finalization);
558 void ParseTypeParameters(bool parameterizing_class); 558 void ParseTypeParameters(bool parameterizing_class);
559 RawTypeArguments* ParseTypeArguments( 559 RawTypeArguments* ParseTypeArguments(
560 ClassFinalizer::FinalizationKind finalization); 560 ClassFinalizer::FinalizationKind finalization);
561 void ParseMethodOrConstructor(ClassDesc* members, MemberDesc* method); 561 void ParseMethodOrConstructor(ClassDesc* members, MemberDesc* method);
562 void ParseFieldDefinition(ClassDesc* members, MemberDesc* field); 562 void ParseFieldDefinition(ClassDesc* members, MemberDesc* field);
563 void CheckMemberNameConflict(ClassDesc* members, MemberDesc* member); 563 void CheckMemberNameConflict(ClassDesc* members, MemberDesc* member);
564 void ParseClassMemberDefinition(ClassDesc* members, 564 void ParseClassMemberDefinition(ClassDesc* members,
565 TokenPosition metadata_pos); 565 TokenPosition metadata_pos);
566 void CheckFinalInitializationConflicts(const ClassDesc* class_desc,
567 const MemberDesc* member);
566 void ParseParameterType(ParamList* params); 568 void ParseParameterType(ParamList* params);
567 void ParseFormalParameter(bool allow_explicit_default_value, 569 void ParseFormalParameter(bool allow_explicit_default_value,
568 bool evaluate_metadata, 570 bool evaluate_metadata,
569 ParamList* params); 571 ParamList* params);
570 void ParseFormalParameters(bool use_function_type_syntax, 572 void ParseFormalParameters(bool use_function_type_syntax,
571 bool allow_explicit_default_values, 573 bool allow_explicit_default_values,
572 bool evaluate_metadata, 574 bool evaluate_metadata,
573 ParamList* params); 575 ParamList* params);
574 void ParseFormalParameterList(bool use_function_type_syntax, 576 void ParseFormalParameterList(bool use_function_type_syntax,
575 bool allow_explicit_default_values, 577 bool allow_explicit_default_values,
(...skipping 450 matching lines...) Expand 10 before | Expand all | Expand 10 after
1026 1028
1027 intptr_t recursion_counter_; 1029 intptr_t recursion_counter_;
1028 friend class RecursionChecker; 1030 friend class RecursionChecker;
1029 1031
1030 DISALLOW_COPY_AND_ASSIGN(Parser); 1032 DISALLOW_COPY_AND_ASSIGN(Parser);
1031 }; 1033 };
1032 1034
1033 } // namespace dart 1035 } // namespace dart
1034 1036
1035 #endif // RUNTIME_VM_PARSER_H_ 1037 #endif // RUNTIME_VM_PARSER_H_
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698