Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2939533002: Apply transformations after comparing to golden files. (Closed)

Created:
3 years, 6 months ago by ahe
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Apply transformations after comparing to golden files. R=paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/5095646191c54c62927a0848c71dd3a277053d54

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+579 lines, -3116 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/front_end/test/fasta/compile.status View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/front_end/test/fasta/testing/suite.dart View 6 chunks +54 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/classes.dart.direct.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/async_closure_return_type_flatten.dart.strong.expect View 1 chunk +1 line, -25 lines 0 comments Download
M pkg/front_end/testcases/inference/async_closure_return_type_future.dart.strong.expect View 1 chunk +1 line, -25 lines 0 comments Download
M pkg/front_end/testcases/inference/async_closure_return_type_future_or.dart.strong.expect View 1 chunk +1 line, -25 lines 0 comments Download
M pkg/front_end/testcases/inference/block_bodied_lambdas_async_all_returns_are_futures.dart.strong.expect View 1 chunk +7 lines, -30 lines 0 comments Download
M pkg/front_end/testcases/inference/block_bodied_lambdas_async_all_returns_are_values.dart.strong.expect View 1 chunk +7 lines, -30 lines 0 comments Download
M pkg/front_end/testcases/inference/block_bodied_lambdas_async_mix_of_values_and_futures.dart.strong.expect View 1 chunk +7 lines, -30 lines 0 comments Download
M pkg/front_end/testcases/inference/block_bodied_lambdas_async_star.dart.strong.expect View 1 chunk +4 lines, -35 lines 0 comments Download
M pkg/front_end/testcases/inference/block_bodied_lambdas_infer_bottom_async.dart.strong.expect View 1 chunk +7 lines, -53 lines 0 comments Download
M pkg/front_end/testcases/inference/block_bodied_lambdas_infer_bottom_async_star.dart.strong.expect View 1 chunk +7 lines, -59 lines 0 comments Download
M pkg/front_end/testcases/inference/block_bodied_lambdas_infer_bottom_sync_star.dart.strong.expect View 1 chunk +2 lines, -13 lines 0 comments Download
M pkg/front_end/testcases/inference/block_bodied_lambdas_sync_star.dart.strong.expect View 1 chunk +3 lines, -18 lines 0 comments Download
M pkg/front_end/testcases/inference/downwards_inference_async_await.dart.strong.expect View 1 chunk +4 lines, -30 lines 0 comments Download
M pkg/front_end/testcases/inference/downwards_inference_for_each.dart.strong.expect View 1 chunk +38 lines, -216 lines 0 comments Download
M pkg/front_end/testcases/inference/downwards_inference_yield_yield_star.dart.strong.expect View 1 chunk +10 lines, -69 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then.dart.strong.expect View 1 chunk +9 lines, -153 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_2.dart.strong.expect View 1 chunk +9 lines, -153 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_3.dart.strong.expect View 1 chunk +9 lines, -153 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_4.dart.strong.expect View 1 chunk +9 lines, -153 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_5.dart.strong.expect View 1 chunk +9 lines, -153 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_6.dart.strong.expect View 1 chunk +9 lines, -153 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_conditional.dart.strong.expect View 1 chunk +3 lines, -62 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_conditional_2.dart.strong.expect View 1 chunk +3 lines, -62 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_conditional_3.dart.strong.expect View 1 chunk +3 lines, -62 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_conditional_4.dart.strong.expect View 1 chunk +3 lines, -62 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_conditional_5.dart.strong.expect View 1 chunk +3 lines, -62 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_conditional_6.dart.strong.expect View 1 chunk +3 lines, -62 lines 0 comments Download
M pkg/front_end/testcases/inference/future_union_async_conditional.dart.strong.expect View 1 chunk +7 lines, -74 lines 0 comments Download
M pkg/front_end/testcases/inference/future_union_async_conditional_2.dart.strong.expect View 1 chunk +7 lines, -74 lines 0 comments Download
M pkg/front_end/testcases/inference/future_union_downwards.dart.strong.expect View 1 chunk +4 lines, -48 lines 0 comments Download
M pkg/front_end/testcases/inference/future_union_downwards_2.dart.strong.expect View 1 chunk +4 lines, -48 lines 0 comments Download
M pkg/front_end/testcases/inference/future_union_downwards_3.dart.strong.expect View 1 chunk +4 lines, -48 lines 0 comments Download
M pkg/front_end/testcases/inference/future_union_downwards_4.dart.strong.expect View 1 chunk +4 lines, -48 lines 0 comments Download
M pkg/front_end/testcases/inference/future_union_downwards_generic_method_with_future_return.dart.strong.expect View 1 chunk +4 lines, -28 lines 0 comments Download
M pkg/front_end/testcases/inference/future_union_downwards_generic_method_with_generic_return.dart.strong.expect View 1 chunk +3 lines, -27 lines 0 comments Download
M pkg/front_end/testcases/inference/future_union_upwards_generic_methods.dart.strong.expect View 1 chunk +8 lines, -34 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_assign_to_index_full.dart.direct.expect View 1 chunk +16 lines, -16 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_assign_to_index_set_vs_get.dart.direct.expect View 1 chunk +12 lines, -12 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_assign_to_local.dart.direct.expect View 1 chunk +11 lines, -11 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_assign_to_static.dart.direct.expect View 1 chunk +21 lines, -21 lines 0 comments Download
M pkg/front_end/testcases/inference/local_return_and_yield.dart.direct.expect View 1 chunk +10 lines, -111 lines 0 comments Download
M pkg/front_end/testcases/inference/local_return_and_yield.dart.strong.expect View 1 chunk +10 lines, -111 lines 0 comments Download
M pkg/front_end/testcases/inference/top_level_return_and_yield.dart.direct.expect View 1 chunk +10 lines, -111 lines 0 comments Download
M pkg/front_end/testcases/inference/top_level_return_and_yield.dart.strong.expect View 1 chunk +10 lines, -111 lines 0 comments Download
M pkg/front_end/testcases/mixin.dart.direct.expect View 3 chunks +6 lines, -21 lines 0 comments Download
M pkg/front_end/testcases/rasta/issue_000007.dart.direct.expect View 1 chunk +2 lines, -7 lines 0 comments Download
M pkg/front_end/testcases/rasta/issue_000012.dart.direct.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/rasta/issue_000048.dart.direct.expect View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/front_end/testcases/rasta/issue_000053.dart.direct.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/rasta/issue_000080.dart.direct.expect View 1 chunk +4 lines, -10 lines 0 comments Download
M pkg/front_end/testcases/super_rasta_copy.dart.direct.expect View 1 chunk +186 lines, -186 lines 0 comments Download
M pkg/kernel/lib/verifier.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
ahe
3 years, 6 months ago (2017-06-12 20:20:31 UTC) #2
Paul Berry
lgtm
3 years, 6 months ago (2017-06-12 21:06:00 UTC) #3
ahe
3 years, 6 months ago (2017-06-13 07:40:41 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
5095646191c54c62927a0848c71dd3a277053d54 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698