Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 2939523003: Add expectations to infer_local_function_return_type. (Closed)

Created:
3 years, 6 months ago by Paul Berry
Modified:
3 years, 6 months ago
Reviewers:
ahe, scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add expectations to infer_local_function_return_type. Previously this test didn't really test anything. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/e2c2733556069edc647fa4c070d4ec334a46eee5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -4 lines) Patch
M pkg/front_end/test/fasta/strong.status View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_local_function_return_type.dart View 2 chunks +14 lines, -1 line 0 comments Download
M pkg/front_end/testcases/inference/infer_local_function_return_type.dart.strong.expect View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 6 months ago (2017-06-13 19:53:55 UTC) #2
scheglov
LGTM
3 years, 6 months ago (2017-06-13 19:55:18 UTC) #3
Paul Berry
3 years, 6 months ago (2017-06-13 20:31:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e2c2733556069edc647fa4c070d4ec334a46eee5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698