chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerToolbar.java - Issue 2939523002: Hide info menu item in Downloads' search mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerToolbar.java

Issue 2939523002: Hide info menu item in Downloads' search mode (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerToolbar.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerToolbar.java b/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerToolbar.java

index 9006d97ad16f364356fc954d4fd712d1c4851f7a..bb1dc621f80f5a759cd1dbff3d494e531f9effee 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerToolbar.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerToolbar.java

@@ -87,7 +87,7 @@ public class DownloadManagerToolbar extends SelectableListToolbar<DownloadHistor

@Override

protected void onDataChanged(int numItems) {

super.onDataChanged(numItems);

- getMenu().findItem(R.id.info_menu_id).setVisible(numItems > 0);

+ getMenu().findItem(R.id.info_menu_id).setVisible(!mIsSearching && numItems > 0);

}

@Override

« no previous file with comments | « no previous file | no next file » | no next file with comments »