Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js

Issue 2939503002: [DevTools] Clear console on GlobalObjectCleared (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js b/third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js
index bf9eab73c2ae47c222f6b6d3fc7adbcf97a9afeb..c3aafbe89c0433f3f151ab4fc9e1a8b58881d8d7 100644
--- a/third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js
+++ b/third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js
@@ -83,8 +83,6 @@ ConsoleModel.ConsoleModel = class extends Common.Object {
var resourceTreeModel = target.model(SDK.ResourceTreeModel);
if (resourceTreeModel) {
- eventListeners.push(resourceTreeModel.addEventListener(
- SDK.ResourceTreeModel.Events.MainFrameStartedLoading, this._mainFrameStartedLoading, this));
eventListeners.push(resourceTreeModel.addEventListener(
SDK.ResourceTreeModel.Events.MainFrameNavigated, this._mainFrameNavigated, this));
}
@@ -97,6 +95,8 @@ ConsoleModel.ConsoleModel = class extends Common.Object {
SDK.RuntimeModel.Events.ExceptionRevoked, this._exceptionRevoked.bind(this, runtimeModel)));
eventListeners.push(runtimeModel.addEventListener(
SDK.RuntimeModel.Events.ConsoleAPICalled, this._consoleAPICalled.bind(this, runtimeModel)));
+ eventListeners.push(runtimeModel.debuggerModel().addEventListener(
+ SDK.DebuggerModel.Events.GlobalObjectCleared, this._clearIfNecessary, this));
}
var networkManager = target.model(SDK.NetworkManager);
@@ -253,7 +253,7 @@ ConsoleModel.ConsoleModel = class extends Common.Object {
/**
* @param {!Common.Event} event
*/
- _mainFrameStartedLoading(event) {
+ _clearIfNecessary(event) {
if (!Common.moduleSetting('preserveConsoleLog').get())
this._clear();
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698